[WIP] Add support for customizable formatting#933
Open
tmadlener wants to merge 23 commits intoAIDASoft:masterfrom
Open
[WIP] Add support for customizable formatting#933tmadlener wants to merge 23 commits intoAIDASoft:masterfrom
tmadlener wants to merge 23 commits intoAIDASoft:masterfrom
Conversation
As a first step using the ostream_formatter adaptor to re-use the existing operator<<.
Implement the existing operator<< in terms of format_to
Necessary to ensure that things still compile if fmt/ranges.h is included to avoid ambiguities that would otherwise arise because LinkT behaves tuple-like enough to trigger tuple formatting. Collections are ranges so we have to explicitly opt-out.
Also get rid of some hideous string concatenation while we are at it
Claude generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
{u}specifier.ENDRELEASENOTES
fmt::formatter)?This follows roughly the approach outlined in #920 (comment) and is the final piece of the chain towards customizable collection formatting.