[bugfix] Let trust_remote_code take effect#226
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates documentation URLs across the repository to point to the new readthedocs domain and introduces support for the trust_remote_code parameter in the CLI, dataset loaders, and performance summarizers. This change allows the tool to load tokenizers that require remote code execution. Feedback is provided regarding the logic for merging trust_remote_code configurations in synthetic datasets to ensure explicit boolean values are respected, and a suggestion is made to add safety checks for model paths in the summarizer to prevent potential runtime errors.
| request_count = config.get("RequestCount") | ||
| config_type = config.get("Type").lower() | ||
| trust_remote_code = config.get("TrustRemoteCode") | ||
| trust_remote_code = config.get("TrustRemoteCode") or kwargs.get("trust_remote_code", False) # Any place set True will take effect |
There was a problem hiding this comment.
The logic config.get("TrustRemoteCode") or kwargs.get("trust_remote_code", False) might lead to unexpected behavior if TrustRemoteCode is explicitly set to False in the config but trust_remote_code is True in kwargs. While the comment says "Any place set True will take effect", using or will ignore an explicit False from the first source. A more robust way to handle this, if you want to prioritize one or ensure an explicit boolean is respected, would be to check for None specifically.
| perf_datas: Raw performance data | ||
| """ | ||
| tokenizer = AISTokenizer(model_cfg.get("path")) | ||
| tokenizer = AISTokenizer(model_cfg.get("path"), model_cfg.get("trust_remote_code", False)) |
There was a problem hiding this comment.
In _calc_perf_data, the model_cfg.get("path") is used to initialize AISTokenizer. If the path is missing or None, AISTokenizer (which calls os.path.exists) will raise a TypeError. Although model_path is usually validated earlier in the CLI flow, it's safer to ensure the path exists here or handle the potential None value to avoid process crashes during summarization.
|
this pr does not only fix the trust remote code issue and also change the readthedocs ref link. |
Thanks for your contribution; we appreciate it a lot. The following instructions will make your pull request healthier and help you get feedback more easily. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
感谢您的贡献,我们非常重视。以下说明将使您的拉取请求更健康,更易于获得反馈。如果您不理解某些项目,请不要担心,只需提交拉取请求并从维护人员那里寻求帮助即可。
PR Type / PR类型
Related Issue | 关联 Issue
Fixes #(issue ID / issue 编号) / Relates to #(issue ID / issue 编号)
Fixes #183
🔍 Motivation / 变更动机
Please describe the motivation of this PR and the goal you want to achieve through this PR.
请描述您的拉取请求的动机和您希望通过此拉取请求实现的目标。
Let trust_remote_code take effect
📝 Modification / 修改内容
Please briefly describe what modification is made in this PR.
请简要描述此拉取请求中进行的修改。
Let trust_remote_code take effect
📐 Associated Test Results / 关联测试结果
Please provide links to the related test results, such as CI pipelines, test reports, etc.
请提供相关测试结果的链接,例如 CI 管道、测试报告等。
before set trust_remote_code
after set trust_remote_code

Does the modification introduce changes that break the backward compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
是否引入了会破坏下游存储库向后兼容性的更改?如果是,请描述它如何破坏兼容性,以及下游项目应该如何修改其代码以保持与此 PR 的兼容性。
If the modification introduces performance degradation, please describe the impact of the performance degradation and the expected performance improvement.
如果引入了性能下降,请描述性能下降的影响和预期的性能改进。
🌟 Use cases (Optional) / 使用案例(可选)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
如果此拉取请求引入了新功能,最好在此处列出一些用例并更新文档。
✅ Checklist / 检查列表
Before PR:
After PR:
👥 Collaboration Info / 协作信息
🌟 Useful CI Command / 实用的CI命令
/gemini review/gemini summary/gemini help/readthedocs build