Skip to content

[bugfix] Let trust_remote_code take effect#226

Merged
GaoHuaZhang merged 5 commits intoAISBench:masterfrom
SJTUyh:dev
Apr 1, 2026
Merged

[bugfix] Let trust_remote_code take effect#226
GaoHuaZhang merged 5 commits intoAISBench:masterfrom
SJTUyh:dev

Conversation

@SJTUyh
Copy link
Copy Markdown
Collaborator

@SJTUyh SJTUyh commented Mar 31, 2026

Thanks for your contribution; we appreciate it a lot. The following instructions will make your pull request healthier and help you get feedback more easily. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
感谢您的贡献,我们非常重视。以下说明将使您的拉取请求更健康,更易于获得反馈。如果您不理解某些项目,请不要担心,只需提交拉取请求并从维护人员那里寻求帮助即可。

PR Type / PR类型

  • Feature(功能新增)
  • Bugfix(Bug 修复)
  • Docs(文档更新)
  • CI/CD(持续集成/持续部署)
  • Refactor(代码重构)
  • Perf(性能优化)
  • Dependency(依赖项更新)
  • Test-Cases(测试用例更新)
  • Other(其他)

Related Issue | 关联 Issue
Fixes #(issue ID / issue 编号) / Relates to #(issue ID / issue 编号)
Fixes #183

🔍 Motivation / 变更动机

Please describe the motivation of this PR and the goal you want to achieve through this PR.
请描述您的拉取请求的动机和您希望通过此拉取请求实现的目标。

Let trust_remote_code take effect

📝 Modification / 修改内容

Please briefly describe what modification is made in this PR.
请简要描述此拉取请求中进行的修改。

Let trust_remote_code take effect

📐 Associated Test Results / 关联测试结果

Please provide links to the related test results, such as CI pipelines, test reports, etc.
请提供相关测试结果的链接,例如 CI 管道、测试报告等。

  1. synthetic_gen
    before set trust_remote_code
image image

after set trust_remote_code
image

image
  1. mooncake trace
image
  1. sharegpt
image

⚠️ BC-breaking (Optional) / 向后不兼容变更(可选)

Does the modification introduce changes that break the backward compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
是否引入了会破坏下游存储库向后兼容性的更改?如果是,请描述它如何破坏兼容性,以及下游项目应该如何修改其代码以保持与此 PR 的兼容性。

⚠️ Performance degradation (Optional) / 性能下降(可选)

If the modification introduces performance degradation, please describe the impact of the performance degradation and the expected performance improvement.
如果引入了性能下降,请描述性能下降的影响和预期的性能改进。

🌟 Use cases (Optional) / 使用案例(可选)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
如果此拉取请求引入了新功能,最好在此处列出一些用例并更新文档。

✅ Checklist / 检查列表

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues. / 使用预提交或其他 linting 工具来修复潜在的 lint 问题。
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests. / 修复的 Bug 已完全由单元测试覆盖,导致 Bug 的情况应在单元测试中添加。
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness. / 此拉取请求中的修改已完全由单元测试覆盖。如果不是,请添加更多单元测试以确保正确性。
  • All relevant documentation (API docs, docstrings, example tutorials) has been updated to reflect these changes. / 所有相关文档(API 文档、文档字符串、示例教程)已更新以反映这些更改。

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects. / 如果此拉取请求对下游或其他相关项目有潜在影响,应在那些项目中测试此 PR。
  • CLA has been signed and all committers have signed the CLA in this PR. / CLA 已签署,且本 PR 中的所有提交者均已签署 CLA。

👥 Collaboration Info / 协作信息

  • Suggested Reviewers / 建议审核人: @xxx
  • Relevant Module Owners / 相关模块负责人: @xxx
  • Other Collaboration Notes / 其他协作说明:

🌟 Useful CI Command / 实用的CI命令

Command / 命令 Introduction / 介绍
/gemini review Performs a code review for the current pull request in its current state by Gemini. / 对当前拉取请求在当前状态下由 Gemini 执行代码审核。
/gemini summary Provides a summary of the current pull request in its current state by Gemini. / 对当前拉取请求在当前状态下由 Gemini 提供摘要。
/gemini help Displays a list of available commands of Gemini. / 显示 Gemini 可用命令的列表。
/readthedocs build Triggers a build of the documentation for the current pull request in its current state by Read the Docs. / 触发当前拉取请求在当前状态下由 Read the Docs 构建文档。

@SJTUyh SJTUyh had a problem deploying to smoke-test-approval March 31, 2026 12:19 — with GitHub Actions Failure
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates documentation URLs across the repository to point to the new readthedocs domain and introduces support for the trust_remote_code parameter in the CLI, dataset loaders, and performance summarizers. This change allows the tool to load tokenizers that require remote code execution. Feedback is provided regarding the logic for merging trust_remote_code configurations in synthetic datasets to ensure explicit boolean values are respected, and a suggestion is made to add safety checks for model paths in the summarizer to prevent potential runtime errors.

request_count = config.get("RequestCount")
config_type = config.get("Type").lower()
trust_remote_code = config.get("TrustRemoteCode")
trust_remote_code = config.get("TrustRemoteCode") or kwargs.get("trust_remote_code", False) # Any place set True will take effect
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic config.get("TrustRemoteCode") or kwargs.get("trust_remote_code", False) might lead to unexpected behavior if TrustRemoteCode is explicitly set to False in the config but trust_remote_code is True in kwargs. While the comment says "Any place set True will take effect", using or will ignore an explicit False from the first source. A more robust way to handle this, if you want to prioritize one or ensure an explicit boolean is respected, would be to check for None specifically.

perf_datas: Raw performance data
"""
tokenizer = AISTokenizer(model_cfg.get("path"))
tokenizer = AISTokenizer(model_cfg.get("path"), model_cfg.get("trust_remote_code", False))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In _calc_perf_data, the model_cfg.get("path") is used to initialize AISTokenizer. If the path is missing or None, AISTokenizer (which calls os.path.exists) will raise a TypeError. Although model_path is usually validated earlier in the CLI flow, it's safer to ensure the path exists here or handle the potential None value to avoid process crashes during summarization.

@SJTUyh SJTUyh temporarily deployed to smoke-test-approval April 1, 2026 01:32 — with GitHub Actions Inactive
@SJTUyh SJTUyh temporarily deployed to smoke-test-approval April 1, 2026 01:58 — with GitHub Actions Inactive
@zhongzhouTan-coder
Copy link
Copy Markdown
Collaborator

this pr does not only fix the trust remote code issue and also change the readthedocs ref link.
Do we need add more explicit description in the title and description block?

@GaoHuaZhang GaoHuaZhang merged commit 91a4d7e into AISBench:master Apr 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 测试完成后解析结果的时候发生报错,提示需设置trust_remote_code=True

3 participants