chore(examples): drop the GLM-5.2 results/ directory - #94
Merged
Conversation
The three files under examples/sglang_1p1d_glm5.2/results/ carry customer-benchmark numbers and cluster detail that should not ship in a public example kit. Remove the directory and drop the six links that pointed into it (five in README.md, one in engine/bench.sh), keeping the surrounding claims intact without the published numbers. Signed-off-by: yihou <yihou@amd.com>
dorado269
requested review from
JohnQinAMD,
jiejingzhangamd,
limou102 and
xiaobochen-amd
as code owners
August 6, 2026 05:52
jiejingzhangamd
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
examples/sglang_1p1d_glm5.2/results/(3 files, 445 lines) for security reasons — it carries customer-benchmark numbers and cluster detail that should not ship in a public example kit.Why the extra two files changed
results/was linked from six places. Leaving them would ship dead links:README.md— 5 links (quick-start pointer, Contents table row, cache-report note, bench-client note, validation-status table)engine/bench.sh— 1 header commentEach was rewritten to keep the surrounding claim and drop only the pointer to the published numbers. No script behaviour changes;
bash -n engine/bench.shpasses.Verify