Draft
Conversation
Many Linux distributions (such as Debian and Fedora) require man pages for all the commands available to the user; adding one for amd_ucode_info fullfills this requirement. * amd_ucode_info.1: New file. Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Fix the following PEP-8 issues reported by flake8:
./amd_ucode_info.py:3:50: W291 trailing whitespace
./amd_ucode_info.py:28:80: E501 line too long (88 > 79 characters)
./amd_ucode_info.py:29:80: E501 line too long (86 > 79 characters)
./amd_ucode_info.py:36:1: E302 expected 2 blank lines, found 1
./amd_ucode_info.py:40:1: E302 expected 2 blank lines, found 1
./amd_ucode_info.py:44:1: E302 expected 2 blank lines, found 1
./amd_ucode_info.py:55:1: E302 expected 2 blank lines, found 1
./amd_ucode_info.py:59:1: E302 expected 2 blank lines, found 1
./amd_ucode_info.py:125:1: E302 expected 2 blank lines, found 1
./amd_ucode_info.py:140:80: E501 line too long (80 > 79 characters)
./amd_ucode_info.py:166:80: E501 line too long (94 > 79 characters)
./amd_ucode_info.py:176:1: E302 expected 2 blank lines, found 1
./amd_ucode_info.py:221:1: E302 expected 2 blank lines, found 1
./amd_ucode_info.py:223:80: E501 line too long (80 > 79 characters)
./amd_ucode_info.py:237:80: E501 line too long (80 > 79 characters)
./amd_ucode_info.py:274:1: E302 expected 2 blank lines, found 1
./amd_ucode_info.py:307:80: E501 line too long (84 > 79 characters)
./amd_ucode_info.py:362:80: E501 line too long (83 > 79 characters)
./amd_ucode_info.py:369:80: E501 line too long (85 > 79 characters)
./amd_ucode_info.py:395:80: E501 line too long (86 > 79 characters)
./amd_ucode_info.py:408:1: E302 expected 2 blank lines, found 1
./amd_ucode_info.py:434:1: E302 expected 2 blank lines, found 1
./amd_ucode_info.py:436:80: E501 line too long (98 > 79 characters)
./amd_ucode_info.py:439:80: E501 line too long (87 > 79 characters)
./amd_ucode_info.py:441:80: E501 line too long (103 > 79 characters)
./amd_ucode_info.py:460:1: E302 expected 2 blank lines, found 1
./amd_ucode_info.py:466:1: E305 expected 2 blank lines after class or function definition, found 1
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
…section are big enough to contain the data being read Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
…big enough to contain a single record Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
…a terminating zero record Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Add diagmsg, err, and warn functions, and output all errors and warnings via two latter ones. Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
…section Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Implement a test that checks amd_ucode_info output against various microcode containers released over the years. The test downloads the containers into local cache if they are not present there, avoiding potential licensing issues with regards to their distribution. Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
…arsing Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
…r or a raw patch via the command line Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
…ssing from the table Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
…es in the merged microcode
…loading microcode and add gitlab URLs in addition to git.kernel.org ones Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
…eleased microcode files
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first part of the patch set is focused on adding some minimal testing infrastructure that checks against existing microcode container files and some synthetic tests to check various parser core cases. The second one expands on abilities to work with raw patches, which makes sense for fam 17h+ patches, as their CPUID can be reconstructed from the patch level, as Linux does already[1]; with the introduction of the
--generate-missing-equivalence-table-entries, it is now possible to do the following:, thusly filling the gap in missing family 1Ah microcode updates in the
linux-firmwarerepository, based on publicly available ones.Still missing:
Note:
test_published.pyimplements some downloading and caching of missing published microcode containers in order to avoid having those in the repository itself due to their license.The series depends on [2] and starts with various minor changes and cleanups before introducing the tests themselves, to avoid the noise of updating the expected output after introducing those.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=94838d230a6c835c
[2] #2