Skip to content

fix team-sync downgrade on fetch failure#61

Merged
KerwinTsaiii merged 1 commit intodevelopfrom
fix/issue-52-team-sync-failure
Apr 10, 2026
Merged

fix team-sync downgrade on fetch failure#61
KerwinTsaiii merged 1 commit intodevelopfrom
fix/issue-52-team-sync-failure

Conversation

@MioYuuIH
Copy link
Copy Markdown
Contributor

@MioYuuIH MioYuuIH commented Apr 10, 2026

Summary

  • preserve existing github-team memberships when GitHub team fetch fails
  • distinguish unknown team membership from a confirmed empty team list
  • add focused regression coverage for the failure path

Test plan

  • python -m pytest runtime/hub/tests/test_groups.py -q

@MioYuuIH MioYuuIH requested a review from KerwinTsaiii as a code owner April 10, 2026 05:40
@MioYuuIH MioYuuIH added the bug Something isn't working label Apr 10, 2026
@MioYuuIH MioYuuIH self-assigned this Apr 10, 2026
@MioYuuIH MioYuuIH mentioned this pull request Apr 10, 2026
Closed
@KerwinTsaiii KerwinTsaiii merged commit d260e46 into develop Apr 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KerwinTsaiii KerwinTsaiii Awaiting requested review from KerwinTsaiii KerwinTsaiii is a code owner

Assignees

@MioYuuIH MioYuuIH

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MioYuuIH @KerwinTsaiii