CI: skip unsupported Liu_IFACPapersOnLine2025 in JAX tests#3121
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Jan 28, 2026
Merged
CI: skip unsupported Liu_IFACPapersOnLine2025 in JAX tests#3121dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl merged 1 commit intoAMICI-dev:mainfrom
Conversation
Skip the recently added `Liu_IFACPapersOnLine2025` benchmark collection problem. Fixes the following test failure (https://github.com/AMICI-dev/AMICI/actions/runs/21275130982/job/61233254223): `FAILED tests/benchmark_models/test_petab_benchmark_jax.py::test_jax_llh[Liu_IFACPapersOnLine2025] - NotImplementedError: The JAX backend does not support event assignments with implicit triggers.`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3121 +/- ##
==========================================
- Coverage 78.24% 77.56% -0.69%
==========================================
Files 315 315
Lines 20482 20482
Branches 1484 1484
==========================================
- Hits 16027 15887 -140
- Misses 4447 4587 +140
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the recently added
Liu_IFACPapersOnLine2025(Benchmarking-Initiative/Benchmark-Models-PEtab#260) benchmark collection problem.Fixes the following test failure (https://github.com/AMICI-dev/AMICI/actions/runs/21275130982/job/61233254223):
FAILED tests/benchmark_models/test_petab_benchmark_jax.py::test_jax_llh[Liu_IFACPapersOnLine2025] - NotImplementedError: The JAX backend does not support event assignments with implicit triggers.