Fix JAX test failures related to diffrax/optimistix release#3129
Fix JAX test failures related to diffrax/optimistix release#3129
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3129 +/- ##
===========================================
+ Coverage 45.38% 78.22% +32.83%
===========================================
Files 309 315 +6
Lines 20216 20482 +266
Branches 1484 1484
===========================================
+ Hits 9176 16023 +6847
+ Misses 11008 4451 -6557
+ Partials 32 8 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
667fec1 to
6a433e9
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| # For forward type definition in generate_equinox | ||
| matplotlib>=3.7.1 | ||
| optax | ||
| optax==0.2.6 |
dweindl
left a comment
There was a problem hiding this comment.
Is it clear why now so many more steps are required? Either way, thanks for fixing that.
Not completely clear. The diffrax update included changes to the linear interpolation timestepper, which could have fairly broad effects: patrick-kidger/diffrax@v0.7.1...v0.7.2 |
I suspect this has something to do with the optimistix update, which is much bigger in scope (patrick-kidger/optimistix@v0.0.11...v0.1.0) I the future it would be great to track performance across jax/diffrax/optimistix versions. |
No description provided.