Skip to content

Comments

Fix JAX test failures related to diffrax/optimistix release#3129

Merged
BSnelling merged 7 commits intomainfrom
bes/optimistix_test_fixes
Feb 23, 2026
Merged

Fix JAX test failures related to diffrax/optimistix release#3129
BSnelling merged 7 commits intomainfrom
bes/optimistix_test_fixes

Conversation

@BSnelling
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.22%. Comparing base (1c5d990) to head (11b9c90).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3129       +/-   ##
===========================================
+ Coverage   45.38%   78.22%   +32.83%     
===========================================
  Files         309      315        +6     
  Lines       20216    20482      +266     
  Branches     1484     1484               
===========================================
+ Hits         9176    16023     +6847     
+ Misses      11008     4451     -6557     
+ Partials       32        8       -24     
Flag Coverage Δ
cpp 71.69% <ø> (?)
cpp_python 37.85% <ø> (ø)
petab 46.56% <ø> (+10.84%) ⬆️
petab_sciml 13.93% <ø> (?)
python 70.35% <ø> (+31.85%) ⬆️
sbmlsuite-jax 33.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/jax/petab.py 94.00% <ø> (+75.47%) ⬆️

... and 233 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BSnelling BSnelling force-pushed the bes/optimistix_test_fixes branch from 667fec1 to 6a433e9 Compare February 23, 2026 12:28
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedoptax@​0.2.7 ⏵ 0.2.6100100100100100

View full report

# For forward type definition in generate_equinox
matplotlib>=3.7.1
optax
optax==0.2.6
Copy link
Collaborator Author

@BSnelling BSnelling Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #3130 to keep track of this.

@BSnelling BSnelling marked this pull request as ready for review February 23, 2026 15:17
@BSnelling BSnelling requested a review from a team as a code owner February 23, 2026 15:17
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it clear why now so many more steps are required? Either way, thanks for fixing that.

@BSnelling
Copy link
Collaborator Author

Is it clear why now so many more steps are required?

Not completely clear. The diffrax update included changes to the linear interpolation timestepper, which could have fairly broad effects: patrick-kidger/diffrax@v0.7.1...v0.7.2

@BSnelling BSnelling added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit 27184ac Feb 23, 2026
31 checks passed
@dweindl dweindl linked an issue Feb 23, 2026 that may be closed by this pull request
@FFroehlich
Copy link
Member

Is it clear why now so many more steps are required?

Not completely clear. The diffrax update included changes to the linear interpolation timestepper, which could have fairly broad effects: patrick-kidger/diffrax@v0.7.1...v0.7.2

I suspect this has something to do with the optimistix update, which is much bigger in scope (patrick-kidger/optimistix@v0.0.11...v0.1.0)

I the future it would be great to track performance across jax/diffrax/optimistix versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pysb dimerization test fails with JAX

3 participants