Scroll to top using Navbar Aossie logo#1140
Open
JaYRaNa213 wants to merge 1 commit intoAOSSIE-Org:mainfrom
Open
Scroll to top using Navbar Aossie logo#1140JaYRaNa213 wants to merge 1 commit intoAOSSIE-Org:mainfrom
JaYRaNa213 wants to merge 1 commit intoAOSSIE-Org:mainfrom
Conversation
Contributor
📝 WalkthroughWalkthroughThe Navbar component is enhanced with smooth scroll-to-top functionality triggered by clicking the logo and PictoPy title. A cursor-pointer class is added to the logo for improved visual affordance. The implementation prevents default navigation and uses Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1139
Description
Clicking the AOSSIE / PictoPy logo in the navbar should smoothly scroll the page back to the top instead of only acting as a route link.
This improves navigation UX, especially on long landing pages.
Expected Behavior
Proposed Implementation
Handle logo click in Navbar.tsx using window.scrollTo with smooth behavior.
Files Affected
video demo :
Scroll.to.top.mp4
Summary by CodeRabbit
New Features
Style