Open
Conversation
medication_id_to_best_rxcui: include curated mappings
and un-hard-code ETL schema
- compute children_loinc_codes directly without
first computing parent_loinc_codes
- use c_hlevel to cut down parent / child search space
- factor out
- lab_terms: where c_fullname like '\i2b2\Laboratory Tests\%'
- loinc_terms: where c_basecode like 'LOINC:%'
- use just 3 columns for the tricky parent/child part
- Oracle seems to build a temp table for this
Fetched 50 rows in 122.732 seconds
This reverts commit 26d47db.
Cycle 2 Refresh 2 Fixes
…o improve performance.
The encounter query was running for more than 6 hours in B2, versus just under 2 hours in A1. The enctype subquery seemed to be the contributing factor.
The real performance hit came on the observation_fact join. Run time on B2 jumped from 15 minutes to 15 hours. Isolating ob_fact reduced runtime to 1 hour.
This could be moved back to cdm_prep in Heron code. Not sure what's the best fit.
For a proper fix, the pcornet_vital.concept_cd provided by scilhs-ontology will need to be updated.
Level of effort proved to be minimal despite novel work in H2P and SCHILS. Tested okay in STAGEDEV.
The dependency is needed for a join on encounter to eliminate med_admin facts outside the timeline required for CDM.
Arrrrgggggh.
Dispensing 5266
Fixed incorrect join syntax
Update encounter.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.