Function to plot the nomalized derivative#78
Merged
Conversation
rcjackson
requested changes
Feb 19, 2026
rcjackson
left a comment
rcjackson
left a comment
Collaborator
There was a problem hiding this comment.
I would add a unit test to make sure that the plot you get out of this function matches a baseline plot that you know is the correct plot. For more information on how to do this, see https://pytest-mpl.readthedocs.io/en/stable/index.html.
An example of such a test is here: https://github.com/ARM-DOE/ACT/blob/main/tests/plotting/test_contourdisplay.py
You will need to run your test first to get the baseline image you want. Then, from there, you will need to store the baseline image in the baseline sub-directory of tests.
Collaborator
|
Looks good! Nice job on the plotting test. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.