Clean-up + add hygiene checks

.github/workflows/hygiene.yml

@@ -0,0 +1,59 @@
+# SPDX-FileCopyrightText: Copyright 2026 Arm Limited and affiliates.
+#
+# SPDX-License-Identifier: Apache-2.0
+
+name: Hygiene
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    types: [opened, synchronize, reopened]
+  workflow_dispatch:
+
+#* Stop stale workflows when pull requests are updated: https://stackoverflow.com/a/70972844
+#* Does not apply to the main branch.
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
+
+# Declare default permissions as read only.
+permissions: read-all
+
+jobs:
+  hygiene:
+    runs-on: ah-ubuntu_24_04-c7g_2x-50
+    steps:
+      - name: Checkout Tool-Solutions
+        uses: actions/checkout@v6.0.2
+
+      - name: Set up Python
+        uses: actions/setup-python@v6.0.0
+        with:
+          python-version: "3.12"
+
+      - name: Install hygiene tooling
+        run: |
+          python -m pip install --user --no-cache-dir pre-commit==4.5.1 reuse==6.2.0
+          echo "$HOME/.local/bin" >> "$GITHUB_PATH"
+
+      - name: Run whole-repo whitespace check
+        run: pre-commit run trailing-whitespace --all-files
+
+      - name: Run safe whole-repo pre-commit checks
+        run: |
+          set -euo pipefail
+          pre-commit run end-of-file-fixer --all-files
+          pre-commit run mixed-line-ending --all-files
+          pre-commit run check-merge-conflict --all-files
+          pre-commit run check-case-conflict --all-files
+          pre-commit run check-symlinks --all-files
+          pre-commit run check-json --all-files
+          pre-commit run check-yaml --all-files
+          pre-commit run check-added-large-files --all-files
+          pre-commit run check-executables-have-shebangs --all-files
+          pre-commit run check-shebang-scripts-are-executable --all-files
+          pre-commit run ruff-check --all-files
+
+      - name: Run whole-repo REUSE lint
+        run: reuse lint

.pre-commit-config.yaml

@@ -1,4 +1,4 @@
-# SPDX-FileCopyrightText: Copyright 2025 Arm Limited and affiliates.
+# SPDX-FileCopyrightText: Copyright 2025, 2026 Arm Limited and affiliates.
 #
 # SPDX-License-Identifier: Apache-2.0
 
@@ -7,7 +7,8 @@ fail_fast: false
 repos:
   - repo: local
     hooks:
-      # Python/YAML/shell: use hash comments (no --multi-line)
+      # Python/YAML/shell: use hash comments (no --multi-line). This hook
+      # mutates copyright metadata. Do not run this hook with --all-files.
       - id: reuse-annotate-current-year-python-yaml-shell-files
         name: REUSE Annotate (Python add current year, merge)
         language: python
@@ -27,7 +28,8 @@ repos:
         files: '(\.gitignore|\.dockerignore|requirements\.txt|bash_profile|Dockerfile|\.(py|yml|yaml|sh|bash))$'
         stages: [ pre-commit ]
 
-      # JSON/Markdown/welcome.txt: use sidecar .license files
+      # JSON/Markdown/welcome.txt: use sidecar .license files. This hook
+      # mutates copyright metadata. Do not run this hook with --all-files.
       - id: reuse-annotate-current-year-json-and-md
         name: REUSE Annotate (JSON/Markdown/welcome.txt sidecar fallback add current year, merge)
         language: python
@@ -49,6 +51,8 @@ repos:
   - repo: https://github.com/fsfe/reuse-tool
     rev: v6.2.0
     hooks:
+      # File-level REUSE validation for changed files. CI also runs `reuse lint`
+      # across the whole repo because validation is non-mutating.
       - id: reuse-lint-file
         stages: [ pre-commit ]
         name: "REUSE Compliant Copyright and License"
@@ -58,3 +62,38 @@ repos:
     hooks:
       - id: trailing-whitespace
         stages: [ pre-commit ]
+      - id: end-of-file-fixer
+        stages: [ pre-commit ]
+      - id: mixed-line-ending
+        stages: [ pre-commit ]
+      # Cheap changed-file guard for accidentally committed conflict markers.
+      # GitHub detects active merge conflicts, but this also catches conflict
+      # markers committed into files.
+      - id: check-merge-conflict
+        stages: [ pre-commit ]
+      # Avoid adding paths that collide on case-insensitive filesystems.
+      - id: check-case-conflict
+        stages: [ pre-commit ]
+      # Catch symlinks that point to missing targets. This is normally a no-op
+      # for this repo, but keeps broken links from entering via future changes.
+      - id: check-symlinks
+        stages: [ pre-commit ]
+      - id: check-json
+        stages: [ pre-commit ]
+      - id: check-yaml
+        stages: [ pre-commit ]
+      # Only checks newly added files, even when invoked with --all-files.
+      - id: check-added-large-files
+        args: [ --maxkb=1024 ]
+        stages: [ pre-commit ]
+      - id: check-executables-have-shebangs
+        stages: [ pre-commit ]
+      # Keep script shebangs and executable bits consistent for runnable files.
+      - id: check-shebang-scripts-are-executable
+        stages: [ pre-commit ]
+
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.15.15
+    hooks:
+      - id: ruff-check
+        stages: [ pre-commit ]

ML-Frameworks/pytorch-aarch64/.agents/skills/bump-sources/SKILL.md

@@ -57,4 +57,4 @@ Provide:
 
 - A short summary of what changed (hashes/tags/wheels).
 - The edits made to `./versions.sh` (and `./get-source.sh` if changed).
-- Commands run and key results/errors.
+- Commands run and key results/errors.

ML-Frameworks/pytorch-aarch64/CHANGELOG.md

@@ -16,7 +16,7 @@ where `YY` is the year, and `MM` the month of the increment.
 ### Added
 
 ### Changed
- 
+
 ### Removed
 
 ### Fixed

ML-Frameworks/pytorch-aarch64/Dockerfile

@@ -43,7 +43,8 @@ WORKDIR /home/$DOCKER_USER
 ENV PATH="/home/$DOCKER_USER/.local/bin:${PATH}"
 
 # Install uv for quicker package installations (installed to ~/.local/bin with --user)
-RUN python -m pip install --user uv==0.9.29
+ENV UV_NO_CACHE=1
+RUN python -m pip install --no-cache-dir --user uv==0.9.29
 
 # Create virtual environment with uv
 RUN uv venv /home/$DOCKER_USER/.venv

ML-Frameworks/pytorch-aarch64/examples/executor/model.py

@@ -8,7 +8,6 @@
 import os
 import runpy
 import time
-import sys
 from urllib.parse import urlparse
 import warnings
 import zipfile

ML-Frameworks/pytorch-aarch64/examples/quantized_linear.py

@@ -67,4 +67,4 @@ def forward(self, x):
         model(data)
         runtimes.append(time.time() - t0)
 
-print('Quantized: %.4fms, FP32: %.4fms, Speedup: %.4f' % (np.min(runtimes)*1e3, np.min(fp32_runtimes)*1e3, np.min(fp32_runtimes)/np.min(runtimes)))
+print('Quantized: %.4fms, FP32: %.4fms, Speedup: %.4f' % (np.min(runtimes)*1e3, np.min(fp32_runtimes)*1e3, np.min(fp32_runtimes)/np.min(runtimes)))

ML-Frameworks/pytorch-aarch64/examples/transformers_llm_text_gen.py

@@ -158,8 +158,7 @@ def eval_quantized_output(quantized_model, tokenizer, input_tensor, max_min_toke
 
 
 def main(args):
-    name_string = f"{args.model}"
-    quantized_model_, tokenizer_, config_ = get_quantized_model(args)
+    quantized_model_, tokenizer_, _ = get_quantized_model(args)
     input_tensor = tokenizer_.encode(args.prompt, return_tensors="pt")
     eval_quantized_output(
         quantized_model_, tokenizer_, input_tensor, args.max_new_tokens

ML-Frameworks/pytorch-aarch64/examples/utils/image.py

@@ -247,7 +247,8 @@ def _postprocess_image_for_openimages_detection(
 
         # resizing the box values from the 800x800 image to the original
         # resolution.
-        resize = lambda x, orig: int((x / 800) * orig)
+        def resize(x, orig):
+            return int((x / 800) * orig)
         left = resize(box[0], width)
         top = resize(box[1], height)
         right = resize(box[2], width)

ML-Frameworks/pytorch-aarch64/examples/utils/vision_parser.py

@@ -61,7 +61,7 @@ def parse_arguments():
     else:
         try:
             os.path.isfile(args["image"])
-        except:
+        except Exception as _:
             assert False, "Image not found"
 
     return args

ML-Frameworks/tensorflow-aarch64/.gitignore

@@ -1,7 +1,7 @@
-# SPDX-FileCopyrightText: Copyright 2025 Arm Limited and affiliates.
+# SPDX-FileCopyrightText: Copyright 2025, 2026 Arm Limited and affiliates.
 #
 # SPDX-License-Identifier: Apache-2.0
 
 tensorflow/
 results/
-*.whl
+*.whl

ML-Frameworks/tensorflow-aarch64/Dockerfile

@@ -38,7 +38,8 @@ WORKDIR /home/$DOCKER_USER
 ENV PATH="/home/$DOCKER_USER/.local/bin:${PATH}"
 
 # Install uv for quicker package installations (installed to ~/.local/bin with --user)
-RUN python -m pip install --user uv==0.9.29
+ENV UV_NO_CACHE=1
+RUN python -m pip install --no-cache-dir --user uv==0.9.29
 
 # Create virtual environment with uv
 RUN uv venv /home/$DOCKER_USER/.venv

ML-Frameworks/tensorflow-aarch64/examples/executor/model.py

@@ -13,7 +13,6 @@
 import zipfile
 
 import numpy as np
-import yaml
 from tqdm import tqdm
 
 import tensorflow as tf

ML-Frameworks/tensorflow-aarch64/examples/utils/vision_parser.py

@@ -89,7 +89,7 @@ def parse_arguments():
     else:
         try:
             os.path.isfile(args["image"])
-        except:
+        except Exception as _:
             assert False, "Image not found"
 
     return args