-
Notifications
You must be signed in to change notification settings - Fork 28
feat: Add vendor test infrastructure framework #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add vendor test infrastructure framework #222
Conversation
ashishsingha
commented
Jan 29, 2026
- Add vendor test numbering scheme in acs_common.h (10000+ range)
- Add vendor test template and documentation in test_pool/vendor/
- Add verify_vendor_inf.sh script to check vendor INFs are in sync
- Update acsbuild.sh to support vendor builds with two-argument syntax
- Vendor builds auto-verify upstream sync before building
|
@chetan-rathore @SrikarJosyula Please review this as well. As mentioned in the commit message, this adds framework for silicon vendors to add tests and build as part of the general ACS framework. |
07ede3d to
3a4e67b
Compare
- Add vendor test numbering scheme in acs_common.h (10000+ range) - Add vendor test template and documentation in test_pool/vendor/ - Add verify_vendor_inf.sh script to check vendor INFs are in sync - Update acsbuild.sh to support vendor builds with two-argument syntax - Vendor builds auto-verify upstream sync before building Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
3a4e67b to
7bdf348
Compare
|
Thanks @ashishsingha for the PR—vendor-specific test addition looks like an interesting feature; we’ll review it and share feedback. ACS follows a Test Pool → VAL → PAL layered structure (methodology: https://github.com/ARM-software/sysarch-acs/blob/main/docs/bsa/arm_bsa_architecture_compliance_validation_methodology.pdf). If new tests are being added into ACS, we expect there may also be corresponding updates needed in VAL/PAL. Could you please share whether you’ve already built and run the additional tests with the current ACS, and whether any required VAL/PAL changes were integrated into the existing VAL/PAL or compiled separately and linked as external libraries? |
Vendors can use this in 2 ways. They may have tests related to their IP that they choose to keep downstream, thus not requiring any modification to the VAL/PAL layers. For cases where someone makes enhancements, I expect users to upstream those changes if they choose not maintain them. I have locally validated both approaches, and I see them working seamlessly. |
@chetan-rathore Any update on this? |
|
Hi @ashishsingha, |