Add maybe async functionality and examples#3
Add maybe async functionality and examples#3ScottGibb wants to merge 1 commit intoATOVproject:mainfrom
Conversation
|
@chmanie Happy to make any changes you want as well :) |
|
Hey @ScottGibb! Sorry again for the delayed reply, I've been incredibly busy in the past weeks. I took a look at your PR and it all looks very reasonable. I just thought about whether we should try to make these changes upstream to the original repo at https://github.com/wez/drv2605. Did you try to contact @wez, the owner? I feel it would make more sense to contribute to the drv2605 project, not mine which has "async" in its name. What do you think? |
|
@ScottGibb I reached out to them on Matrix. Let's wait and see. In case we're not successful, we can continue development here. |
|
I have a lot of repos and set them to notify only on at-mentions, so I didn't see those things over there. I'm definitely open to collaborating and syncing things up, however, I'm currently in the middle of moving between countries so have very little time, and no access to my electronics lab or parts while things are moving across the ocean. |
|
@wez No problem at all! Hoping your move goes well. I just helped my girlfriend move, I know the stress all to well. Hope it goes well and we can all sync up in the future! |
Thanks @chmanie for creating the async version of the main DRV2605 driver. We found it incredibly useful.
We were hoping to PR back some useful functionality that allows the driver to be used for both async and sync hals, through maybe_async. This reduces boilerplate code and provides the same API no matter which hal you are using.
We also added some examples to the repo as well that mirror the adafruit examples from the original driver written for arduino.
We hope you find this useful and we would love to add more github workflows and other features as they come up.
Thanks
@ScottGibb
@petekubiak