Alternative fixes for FP-Grids phasing and clock div issues#477
Open
rjsmith wants to merge 11 commits intoATOVproject:feat/fp-grid-reworkfrom
Open
Alternative fixes for FP-Grids phasing and clock div issues#477rjsmith wants to merge 11 commits intoATOVproject:feat/fp-grid-reworkfrom
rjsmith wants to merge 11 commits intoATOVproject:feat/fp-grid-reworkfrom
Conversation
…nd tick() functions, no longer required
Collaborator
Author
|
I've added code to restore the internal sequence step state of the Grids pattern generator library struct, e.g. when an app is re-spawned after a Configurator app change. It seems to work OK, including code to ensure playing midi notes are stopped after the re-spawn (to prevent hanging MIDI notes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the new pattern generator code that double-stepped the Drum mode sequence. Instead, Drums Mode now uses a simple fixed clock division of 1/32nd notes to match the original firmware. I don't think this mode needs ability to vary the clock division (making it more complex to use) .. there is a lot you can do with just moving the channel density sliders to vary the rhythmic pulse of the pattern.
Euclidean mode uses the clock divider, that works just fine. If it seems too complex that only one of three modes has a built-in clock divider, we could just remove it from Euclidean mode to match the OG firmware (there is always the FP's own Euclid app if anyone wants that).
This MR also adds a not very carefully hidden Easter Egg mode, documented in the fp_grids.rs file. 🥁