Skip to content

Alternative fixes for FP-Grids phasing and clock div issues#477

Open
rjsmith wants to merge 11 commits intoATOVproject:feat/fp-grid-reworkfrom
rjsmith:feat/fp-grids-rework-egg
Open

Alternative fixes for FP-Grids phasing and clock div issues#477
rjsmith wants to merge 11 commits intoATOVproject:feat/fp-grid-reworkfrom
rjsmith:feat/fp-grids-rework-egg

Conversation

@rjsmith
Copy link
Collaborator

@rjsmith rjsmith commented Mar 13, 2026

Removed the new pattern generator code that double-stepped the Drum mode sequence. Instead, Drums Mode now uses a simple fixed clock division of 1/32nd notes to match the original firmware. I don't think this mode needs ability to vary the clock division (making it more complex to use) .. there is a lot you can do with just moving the channel density sliders to vary the rhythmic pulse of the pattern.

Euclidean mode uses the clock divider, that works just fine. If it seems too complex that only one of three modes has a built-in clock divider, we could just remove it from Euclidean mode to match the OG firmware (there is always the FP's own Euclid app if anyone wants that).

This MR also adds a not very carefully hidden Easter Egg mode, documented in the fp_grids.rs file. 🥁

@rjsmith rjsmith requested a review from ArthurGibert March 13, 2026 20:27
@rjsmith
Copy link
Collaborator Author

rjsmith commented Mar 17, 2026

I've added code to restore the internal sequence step state of the Grids pattern generator library struct, e.g. when an app is re-spawned after a Configurator app change. It seems to work OK, including code to ensure playing midi notes are stopped after the re-spawn (to prevent hanging MIDI notes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant