Skip to content

Feat/theme switcher blacksky#24

Open
grishaLR wants to merge 6 commits into
ATProtocol-Community:mainfrom
grishaLR:feat/theme-switcher-blacksky
Open

Feat/theme switcher blacksky#24
grishaLR wants to merge 6 commits into
ATProtocol-Community:mainfrom
grishaLR:feat/theme-switcher-blacksky

Conversation

@grishaLR
Copy link
Copy Markdown
Contributor

@grishaLR grishaLR commented May 9, 2026

overview

Note

the massive diff is from: @atproto/common-web missing for me locally so i added it. also ended up generating a full lockfile. will follow your lead on how you'd like to resolve these

this closes issue #9 supporting themes - after this PR everything is in place for anyone to cut a PR to add a theme!!

this PR brings in Blacksky theme and a theme switcher! woohoo! adds instructions for how to contribute

on thing to note: @atproto/common-web was missing and broke the events tab so i added that

description

pretty straight forward!

  • renames CSS var --border to --border-color
  • adds contributing docs
  • adds theme switcher dropdown
  • adds Blacsky theme
  • adds missing dep @atproto/common-web that broke the page when navigating to/communities
09:19:10 [ERROR] Cannot find module '@atproto/common-web' imported from '/Users/grisha/code/atproto-community/src/lib/rsvps.ts'
  Stack trace:
    at fetchModule (file:///Users/grisha/code/atproto-community/node_modules/.pnpm/vite@7.3.3_yaml@2.8.4/node_modules/vite/dist/node/chunks/config.js:34000:34)
    at fetchModule (file:///Users/grisha/code/atproto-community/node_modules/.pnpm/vite@7.3.3_yaml@2.8.4/node_modules/vite/dist/node/chunks/config.js:34810:17)
    at EventEmitter.listenerForInvokeHandler (file:///Users/grisha/code/atproto-community/node_modules/.pnpm/vite@7.3.3_yaml@2.8.4/node_modules/vite/dist/node/chunks/config.js:25908:19)
    at Object.send (file:///Users/grisha/code/atproto-community/node_modules/.pnpm/vite@7.3.3_yaml@2.8.4/node_modules/vite/dist/node/chunks/config.js:15068:39)
    at Object.invoke (file:///Users/grisha/code/atproto-community/node_modules/.pnpm/vite@7.3.3_yaml@2.8.4/node_modules/vite/dist/node/module-runner.js:584:31)
09:19:35 Configuration file updated. Restarting...
[vite] connected.

screengrabs

blacksky-themeswitcher.mp4

Comment thread pnpm-lock.yaml
@@ -0,0 +1,4223 @@
lockfileVersion: '9.0'
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@essential-randomness should i remove the lockfile? i was surprised by this addition...

Comment thread package.json
"@astrojs/check": "^0.9.8",
"@astrojs/node": "^10.0.5",
"@atproto/api": "^0.17.3",
"@atproto/common-web": "^0.4.21",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure how this diverged... the /communites page broke for me locally but is working in production 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant