fix(ci): re-pin publish-single-page-docs to a working upstream SHA - #95
Merged
Conversation
The SHA pinned by #93 (679ec07) ships a broken action manifest: the `github-token` description contains an unquoted `: ` inside backticks, so the runner cannot parse action.yml and the job dies during "Set up job". Run 30910992670 on master failed exactly this way. Upstream fixed it in fa935dc ("quote colon-containing description ..."), which also adds action-manifest validation to the knowledge-base CI. The pin is bumped by hand: AbsaOSS/knowledge-base publishes no tags and no releases, so Dependabot's github-actions ecosystem has nothing to resolve the SHA forward to. A two-line comment records that so the next reader does not inherit the assumption made on #93. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GdafNH5D2xP8QNjo1yBE8Y
oto-macenauer-absa
requested review from
miroslavpojer and
tmikula-dev
as code owners
August 4, 2026 13:32
WalkthroughThis PR updates the pinned commit reference for the ChangesAction Pin Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tmikula-dev
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The
Publish Docsworkflow added in #93 cannot run. It pinsAbsaOSS/knowledge-base/actions/publish-single-page-docsat679ec075cab1e1cdfb1140eedad7f2f80a5b683a, and the action manifest at thatcommit is invalid YAML — the
github-tokendescription holds an unquoted:(colon-space) inside backticks, which YAML reads as a nested mapping:The runner therefore fails while loading the manifest, before any step runs.
This already happened in production: run
30910992670onmaster(
workflow_dispatch) failed withUpstream fixed the manifest in
fa935dc6ed1aae54d295e457424ee636914147c3(
fix: quote colon-containing description in publish-single-page-docs action manifest (#40)), which also added action-manifest validation to theknowledge-base CI so the class of bug should not recur there. This PR bumps
the pin to that commit.
A second point worth recording: the review discussion on #93 assumed the
github-actionsDependabot group would keep this pin fresh. It will not.Dependabot resolves a pinned action SHA forward to the SHA of the newest
release or tag, and
AbsaOSS/knowledge-basecurrently publishes 0 tags and0 releases — there is nothing to resolve to, so the pin would have sat on
the broken commit indefinitely. Pinning is still correct and stays; the
workflow now carries a two-line comment saying the bump is manual, so the
next reader does not inherit the same assumption.
Verification performed before pushing:
action.ymlatfa935dcfetched over the API (HTTP 200, so the action pathexists at that SHA) and
yaml.safe_loadparses it cleanly; inputs aredocs,github-token,release-tagas expected..github/workflows/publish_docs.ymlparses, and everyuses:in itresolves to a bare 40-hex SHA ref.
docs:entry is byte-identical to feat(docs): publish documentation to the AbsaOSS knowledge base #93 — slugorg-workflows-security,icon
shield, tags[security, automation, aquasec, workflows], and therelease-tagexpression untouched.src/is unchanged between the local clone andfa935dc; the only diff isaction.ymlplus the new CI job). It rendereddocs/security/security.md→org-workflows-securitywith Mermaid supportand packed a 753 KB bundle successfully. Output was written to a scratch
directory, not into the repo.
Only the pinned SHA and the new comment change; nothing else in the workflow
was touched.
Release Notes
Publish Docsworkflow, which failed to start because the pinnedpublish-single-page-docsaction revision contained an unparsable actionmanifest.
AbsaOSS/knowledge-base/actions/publish-single-page-docstofa935dc6ed1aae54d295e457424ee636914147c3, the upstream commit that fixesthe manifest.
upstream repository publishes no tags or releases and Dependabot cannot
track it.
Related
Closes #94
Summary by CodeRabbit