feat: show individual approver addresses in ApprovalBar tooltip#198
Merged
thegreatfeez merged 1 commit intoJun 26, 2026
Merged
Conversation
|
@Yash-Karakoti is attempting to deploy a commit to the thegreatfeez's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Yash-Karakoti Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the issue where the
ApprovalBarcomponent rendered individual owner approval slots as colored dots without providing any visual feedback on who signed off.We added a parallelized on-chain check helper to fetch specific approvers for a proposal, updated the proposal hook data lifecycle, extended the core types, and attached a truncated address tooltip directly to the native HTML
titleattributes of the approved slots.Key Changes:
frontend/src/types/accord.ts: AddedapproverAddresses: string[]to theProposaltype to carry on-chain signer identities.frontend/src/lib/contract.ts:getApprovers(proposalId)that parallelizes calls tohasApprovedacross all multisig owners.approverAddresses: []within themapProposaltransformer to satisfy strict compiler typing.frontend/src/hooks/useContract.ts: Updated the mapping pipeline to resolve and bind the on-chainapproverAddressesfor each proposal inside the core state fetching loop.frontend/src/components/ApprovalBar.tsx: Updated the component to take an optionalapproverAddressesstring array prop and added a truncated tooltip format (e.g.,0x1234...abcd) mapping to the nativetitleattribute for active approval slots.frontend/src/components/ProposalCard.tsx: Passedproposal.approverAddressesthrough toApprovalBar.frontend/src/pages/ProposalDetailPage.tsx&frontend/src/App.tsx: Cleaned up residual syntax/merge-conflict dead code causing compiler noise duringnpm run build.Type of Change
Related Issue
Closes #2
Testing Checklist