Skip to content

feat: show individual approver addresses in ApprovalBar tooltip#198

Merged
thegreatfeez merged 1 commit into
Ac0rdP:mainfrom
Yash-Karakoti:feat/approval-bar-tooltip
Jun 26, 2026
Merged

feat: show individual approver addresses in ApprovalBar tooltip#198
thegreatfeez merged 1 commit into
Ac0rdP:mainfrom
Yash-Karakoti:feat/approval-bar-tooltip

Conversation

@Yash-Karakoti

Copy link
Copy Markdown
Contributor

Summary

This PR resolves the issue where the ApprovalBar component rendered individual owner approval slots as colored dots without providing any visual feedback on who signed off.

We added a parallelized on-chain check helper to fetch specific approvers for a proposal, updated the proposal hook data lifecycle, extended the core types, and attached a truncated address tooltip directly to the native HTML title attributes of the approved slots.

Key Changes:

  • frontend/src/types/accord.ts: Added approverAddresses: string[] to the Proposal type to carry on-chain signer identities.
  • frontend/src/lib/contract.ts:
    • Added an exported async function getApprovers(proposalId) that parallelizes calls to hasApproved across all multisig owners.
    • Initialized approverAddresses: [] within the mapProposal transformer to satisfy strict compiler typing.
  • frontend/src/hooks/useContract.ts: Updated the mapping pipeline to resolve and bind the on-chain approverAddresses for each proposal inside the core state fetching loop.
  • frontend/src/components/ApprovalBar.tsx: Updated the component to take an optional approverAddresses string array prop and added a truncated tooltip format (e.g., 0x1234...abcd) mapping to the native title attribute for active approval slots.
  • frontend/src/components/ProposalCard.tsx: Passed proposal.approverAddresses through to ApprovalBar.
  • frontend/src/pages/ProposalDetailPage.tsx & frontend/src/App.tsx: Cleaned up residual syntax/merge-conflict dead code causing compiler noise during npm run build.

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor

Related Issue

Closes #2

Testing Checklist

  • Existing tests pass locally
  • New tests added to cover this change (where applicable)
  • Manually verified the change works as expected
  • Lint / type checks pass

@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

@Yash-Karakoti is attempting to deploy a commit to the thegreatfeez's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jun 26, 2026

Copy link
Copy Markdown

@Yash-Karakoti Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@thegreatfeez thegreatfeez merged commit 106211c into Ac0rdP:main Jun 26, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show individual approver addresses in ApprovalBar tooltip

2 participants