Issue #2228 - Out-of-bounds issue in ThrowInvalidRegex #2231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in OpenColorIO::ThrowInvalidRegex This turned out to be not a UAF issue but an out-of-bounds-access issue where the throw was accessing the incorrect (and potentially shorter) string with an index derived from another (and potentially longer) string. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
cozdas
commented
Jan 5, 2026
| if (globString[idx] == ']') | ||
| { | ||
| ThrowInvalidRegex(globPattern, globPattern + idx); | ||
| ThrowInvalidRegex(globPattern, &globString[idx]); |
Collaborator
Author
There was a problem hiding this comment.
idx is looping through the globString content which is a potentially longer string (for example when ignore space is true, which expands every alpha character to [xX] string). So it was trying to access pass end of globPattern.
doug-walker
changed the title
KevinJW
approved these changes
Jan 6, 2026
Contributor
KevinJW
left a comment
KevinJW
left a comment
There was a problem hiding this comment.
Looks good to me.
Finding this kind of bug in this code, not that surprising
remia
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing Issue #2228 - Heap-use-after-free in OpenColorIO::ThrowInvalidRegex
This turned out to be not a UAF issue but an out-of-bounds-access issue where the throw was accessing the incorrect (and potentially shorter) string with an index derived from another (and potentially longer) string.