Settings additions#165
Conversation
Signed-off-by: Cameron Target <camerontarget@gmail.com>
Signed-off-by: Cameron Target <camerontarget@gmail.com>
|
I like the new layout and the ability to switch between Version or Workon details. I still do not think we need a global toggle in the settings for the AI features. The only reason I can think of that this would be needed is if a facility has not setup vexa or an LLM. In these cases, I think a toggle in the .env file makes such more sense. As part of this PR, can we make the settings fixed to a percentage of the VH and have the settings area scrollable? At the moment it changes size of the whole page. |
| <Eye size={14} /> | ||
| In Review | ||
| </InReviewButton> | ||
| {transcriptionEnabled && ( |
There was a problem hiding this comment.
Do not gate the "In Review" behind transcription. It is used in workflows beyond transcription in studio envs (call to dailies for example). I do not think we need these feature flags at all TBH.
There was a problem hiding this comment.
OK, what's call to dailies? 👀
There was a problem hiding this comment.
In many studios, there are workflows that exists to tell artists when they should come to dailies in case it is really long. By tracking what is being reviewed, artists can tell how far away thier submission is from being reviewed and know when to join the call/head to the review room. At ILM we have a fancy notification system that will pop up on an artists machine if there version is coming up (like 2-5 versions away) from the in-review one. Since this could be used in other workflows, I do not think it should be gated vs transcription.
There was a problem hiding this comment.
Understood, okay, thanks for the context!
I imagine you won't love the fact that I put in-review behind another feature flag, but I did decouple it from transcription! Will be all ears today when we discuss, in-review currently defaults to on, I'm hoping you might be on board with that!
Settings modal capped at `70vh` with a fixed footer (Close button + border line always anchored at the bottom) - Tab content area scrolls vertically within the remaining space instead of pushing the footer around - Horizontal scroll disabled on all tabs Signed-off-by: Cameron Target <camerontarget@gmail.com>
In Review is used in workflows beyond transcription (e.g. call-to-dailies), so it now has its own toggle in the General settings tab, defaulting to on. Transcription and AI flags are unchanged and still default off (to be discussed) Signed-off-by: Cameron Target <camerontarget@gmail.com>
Notes from our DNA Sync
|
Signed-off-by: Cameron Target <camerontarget@gmail.com>
Signed-off-by: Cameron Target <camerontarget@gmail.com>
auto-sync effect treated the initial version as a "version change" and opened a tab. It now only syncs into a tab the user already opened with the "PT tab" button (gated on a controlled tab id), only fires on an actual version change, and uses the extension-only call so a failed sync never spawns a new window. The manual button still opens/focuses the tab. Signed-off-by: Cameron Target <camerontarget@gmail.com>
|
Added cascading 'russian doll' dependencies for settings toggles as well as pipeline level overrides in the frontend .env. Tooltips all around! 
|
| # setting VITE_FEATURE_AI=true effectively enables all three; setting | ||
| # VITE_FEATURE_IN_REVIEW=false does NOT disable In Review while a parent is on. | ||
| # VITE_FEATURE_TRANSCRIPTION= | ||
| # VITE_FEATURE_IN_REVIEW= |
There was a problem hiding this comment.
I think we should just leave the in-review functionality on instead of putting behind a feature flag.
jspada200
left a comment
jspada200
left a comment
There was a problem hiding this comment.
few small things then this LGTM
Signed-off-by: Cameron Target <camerontarget@gmail.com>
|
Hi @jspada200 I added the boostrap configuration and enabled all the features by default in the user UI. I think env stuff should be configured separately by pipe TDs when the tool is being used at a studio! |
2 participants
Summary
I moved some settings around and (currently) have them disabled by default. I also put together a setting for which page to sync with ShotGrid and the chrome plugin. I used Claude Code, plugged into my Zed code editor to make these changes.
Testing
How I Tested
I stood the application up and tried a few different configurations.