Skip to content

Added support for specifying timelines to import via custom URI #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tedwaine merged 1 commit into from
Feb 4, 2026
+104 −43
Merged

Added support for specifying timelines to import via custom URI #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 61 additions & 43 deletions src/playlist/src/playlist_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1916,50 +1916,68 @@ caf::message_handler PlaylistActor::message_handler() {

try {
caf::scoped_actor sys(system());
auto global = system().registry().template get<caf::actor>(global_registry);
auto epa = request_receive<caf::actor>(*sys, global, global::get_python_atom_v);
// spdlog::warn("Load from python");
// request otio xml from embedded_python.
mail(session::import_atom_v, path)
.request(epa, infinite)
.then(
[=](const std::string &data) mutable {
// got data create timeline and load it..
const auto name = fs::path(uri_to_posix_path(path)).stem().string();
// spdlog::warn("Loaded from python {}", name);
mail(create_timeline_atom_v, name, uuid_before, false, false)
.request(actor_cast<caf::actor>(this), infinite)
.then(
[=](const utility::UuidUuidActor &uua) mutable {
// request loading of timeline
if (not wait) {
anon_mail(session::import_atom_v, path, data)
.send(uua.second.actor());
rp.deliver(uua.second);
} else {
mail(session::import_atom_v, path, data)
.request(uua.second.actor(), infinite)
.then(
[=](const bool) mutable {
rp.deliver(uua.second);
},

[=](error &err) mutable {
spdlog::warn(
"{} {}",
__PRETTY_FUNCTION__,
to_string(err));
rp.deliver(std::move(err));
});
}
},
[=](error &err) mutable {
spdlog::warn(
"{} {}", __PRETTY_FUNCTION__, to_string(err));
rp.deliver(std::move(err));
});
},
[=](error &err) mutable { rp.deliver(std::move(err)); });
if (path.scheme() != "file") {

// Send path URI to data_source plugins to create and populate the timeline.
auto pm = system().registry().template get<caf::actor>(plugin_manager_registry);
mail(data_source::use_data_atom_v, path,
caf::actor_cast<caf::actor>(this), base_.media_rate(), uuid_before, wait)
.request(pm, infinite)
.then(
[=](const UuidActor &ua) mutable {
rp.deliver(ua);
},
[=](error &err) mutable { rp.deliver(std::move(err)); });

} else {

auto global = system().registry().template get<caf::actor>(global_registry);
auto epa = request_receive<caf::actor>(*sys, global, global::get_python_atom_v);
// spdlog::warn("Load from python");
// request otio xml from embedded_python.
mail(session::import_atom_v, path)
.request(epa, infinite)
.then(
[=](const std::string &data) mutable {
// got data create timeline and load it..
const auto name = fs::path(uri_to_posix_path(path)).stem().string();
// spdlog::warn("Loaded from python {}", name);
mail(create_timeline_atom_v, name, uuid_before, false, false)
.request(actor_cast<caf::actor>(this), infinite)
.then(
[=](const utility::UuidUuidActor &uua) mutable {
// request loading of timeline
if (not wait) {
anon_mail(session::import_atom_v, path, data)
.send(uua.second.actor());
rp.deliver(uua.second);
} else {
mail(session::import_atom_v, path, data)
.request(uua.second.actor(), infinite)
.then(
[=](const bool) mutable {
rp.deliver(uua.second);
},

[=](error &err) mutable {
spdlog::warn(
"{} {}",
__PRETTY_FUNCTION__,
to_string(err));
rp.deliver(std::move(err));
});
}
},
[=](error &err) mutable {
spdlog::warn(
"{} {}", __PRETTY_FUNCTION__, to_string(err));
rp.deliver(std::move(err));
});
},
[=](error &err) mutable { rp.deliver(std::move(err)); });

}
} catch (const std::exception &err) {
rp.deliver(make_error(xstudio_error::error, err.what()));
}
Expand Down
43 changes: 43 additions & 0 deletions src/plugin_manager/src/plugin_manager_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,49 @@ PluginManagerActor::PluginManagerActor(caf::actor_config &cfg) : caf::event_base
return rp;
},

// helper for dealing with URI's that create and return a timeline
[=](data_source::use_data_atom,
const caf::uri &uri,
const caf::actor &playlist_actor,
const FrameRate &media_rate,
const utility::Uuid &uuid_before,
const bool wait) -> result<UuidActor> {
// send to resident enabled datasource plugins
auto actors = std::vector<caf::actor>();

for (const auto &i : manager_.factories()) {
if (i.second.factory()->type() & PluginFlags::PF_DATA_SOURCE and
resident_.count(i.first))
actors.push_back(resident_[i.first]);
}

if (actors.empty())
return UuidActor();

auto rp = make_response_promise<UuidActor>();

fan_out_request<policy::select_all>(
actors,
infinite,
data_source::use_data_atom_v,
uri,
playlist_actor,
media_rate,
uuid_before,
wait)
.then(
[=](const std::vector<UuidActor> results) mutable {
for (const auto &i : results) {
if (i)
return rp.deliver(i);
}
rp.deliver(UuidActor());
},
[=](error &err) mutable { rp.deliver(std::move(err)); });

return rp;
},

// helper for dealing with Media sources back population's
[=](data_source::use_data_atom,
const caf::actor &media,
Expand Down
Loading