-
Notifications
You must be signed in to change notification settings - Fork 104
Bugfix: Osx drag window across screen fix. #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
richardssam
wants to merge
38
commits into
AcademySoftwareFoundation:main
from
richardssam:osx-drag-window-fix
Closed
Bugfix: Osx drag window across screen fix. #194
richardssam
wants to merge
38
commits into
AcademySoftwareFoundation:main
from
richardssam:osx-drag-window-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
…annotation_serialiser.cpp. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
…List, and Timecode. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
…ed as MS_MISSING. This allows for media_sources to be provided by http(s). Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
…ore file exists in a thumbnail cache directory. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
…sage. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
…data value through xstudio's file-path remapping mechanism. Likewise, all the search paths within the config are also passed through file path remapping. Note that any path set via the OCIO environment variable is left as-is. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
…ur management metadata. We use this to set the working_space to "raw" for media we want to remain unmanaged but still allow for the global view to be set without causing error messages. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
… Ctrl+1 through Ctrl+9 (linux) and each select the the corresponding view for the current display. Under MacOS these are Cmd+1 through Cmd+9. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Signed-off-by: Thomas Manceau <manceau.thomas19@gmail.com>
Signed-off-by: Thomas Manceau <manceau.thomas19@gmail.com>
Updated version of openimageio from 2.5.19.1 to 2.5.16.0#1. Signed-off-by: Thomas Manceau <manceau.thomas19@gmail.com>
…re/implement-oiio-reader AcademySoftwareFoundation#98: Open Image IO Library / Reader
…ure_remove_media_sources Add ability to programatically remove media_source's from media items.
…_fixes_additions Miscellaneous fixes and additions
…_cosmetic_fixes Misc cosmetic fixes
…_additions OCIO view hotkeys, working_space, and file-path remapping
…ure_disable_http_ssl_verify Allow for optionally disabling SSL verification.
Signed-off-by: Hugh Macdonald <hugh@hughmacdonald.co.uk>
…ix-windows-plugin-path AcademySoftwareFoundation#188: Fix environment variable path separator on Windows
…ck window go black if its not the original screen. Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Contributor
Author
|
Going to delete this, since its bringing in devel. Will re-submit it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Osx drag window across screen fix.
[ #193 ] This addresses the issue where the viewer goes black if the window is dragged from one screen to another.
Summarize your change.
The playlist window appears to be configured for a single screen, when you drag the window from one screen to another it will go black, if you drag it back it will become visible again.
I'm using the OnVisibleChanged signal to catch that something has happened, and reinitialize the viewport.
Describe what you have tested and on which operating system.
This has only been tested on OSX, I do not know if there might be issues on windows or linux.
Add a list of changes, and note any that might need special attention during the review.
This seems to work, but while I have a fair bit of experience with PySide I don't have experience with these frameworks, so I could be missing something. There is some logging code, that could go, but it seems like it would be useful for testing on other platforms.