Fix/event subscription group

[jhery-rdo]

Fix subscribe_to_event_group() registering callback on wrong actor

Summary

ModuleBase.subscribe_to_event_group() registers the callback on event_source.remote instead of the retrieved event_group, causing event callbacks to never fire.

The Bug

In module.py line 391:

def subscribe_to_event_group(self, event_source, callback_method):
    event_group = self.connection.request_receive(event_source.remote, get_event_group_atom())[0]
    return self.connection.link.add_message_callback(event_source.remote, callback_method)
    #                                                ^^^^^^^^^^^^^^^^^^^ BUG: should be event_group

The method correctly retrieves the event_group actor but then ignores it, registering the callback on event_source.remote instead.

The Fix

def subscribe_to_event_group(self, event_source, callback_method):
    event_group = self.connection.request_receive(event_source.remote, get_event_group_atom())[0]
    return self.connection.link.add_message_callback(event_group, callback_method)
    #                                                ^^^^^^^^^^^^ FIXED: use event_group

Impact

• Before: Event subscriptions via subscribe_to_event_group() were non-functional. Callbacks were registered on the wrong actor and events were never delivered.
• After: Event subscriptions work as intended. Callbacks receive events from the event group.

Discovery

Found while implementing event-driven bookmark detection in a Python plugin. Studio-level session events were not being received despite successful subscription. Tracing the issue revealed the callback was registered on the wrong actor.

[linux-foundation-easycla]

• ✅ login: Blackhart / name: Thomas Manceau (30c6efc, 9b84190, bf1829e)
• ✅ login: HughMacdonald / name: Hugh Macdonald (e04f89f)
• ✅ login: kenmcgaugh / name: Ken McGaugh (0b01397, 2550081, 2fde4fd, 58d0915, 734d717, 883e334, 88861dd, 8da45af, 92d9289, 9539d3a, a74145b, acfc5c9, b43b188, c2556ca, c5388c1, c6a72ef, e6d277d, fa32aa1)
• ✅ login: tedwaine / name: Ted Waine (0b1c0b0, 32967af, 5f224e8, 6c1c12c, 6c496b1, 8654cc1, 98a8aef, d1bc1d1, ea9e487, fb4db37)
• ✅ login: tedwaine / name: tedwaine (180de28, 469f404, 47f6713, 7c28227, 92487c6, c566cab, d45d24c, e4e48f6, e652306)
• ❌ The email address for the commit (c02f0c9) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[tedwaine]

Hi @nosmose - thanks for this. Would you be able to do the paperwork on the 'EasyCLA' authorisation? Until you do that I can't run the merge. The other problem is that for some reason github is telling me that you're merging 38 commits and changing 300+ files!! Did you mean to do the PR into the develop branch?

[jhery-rdo]

Thanks @tedwaine will close this one and make a cleaner one