Fix event subscription to use event_group instead of event_source.remote #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix subscribe_to_event_group() registering callback on wrong actor
Summary
ModuleBase.subscribe_to_event_group()registers the callback onevent_source.remoteinstead of the retrievedevent_group, causing event callbacks to never fire.Updated PR with a recent rebase on develop branch
The Bug
In
module.pyline 391:The method correctly retrieves the
event_groupactor but then ignores it, registering the callback onevent_source.remoteinstead.The Fix
Impact
subscribe_to_event_group()were non-functional. Callbacks were registered on the wrong actor and events were never delivered.Discovery
Found while implementing event-driven bookmark detection in a Python plugin. Studio-level session events were not being received despite successful subscription. Tracing the issue revealed the callback was registered on the wrong actor.