Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds markdown level 2 heading syntax (## ) before a script tag that loads JavaScript for fetching student count data. This change breaks the functionality of the script by treating it as a heading instead of executable HTML.
Changes:
- Modified the script tag on line 82 to be prefixed with markdown heading syntax
| <script async defer src="https://buttons.github.io/buttons.js"></script> | ||
|
|
||
| <script src="_static/fetch_student_count.js"></script> | ||
| ## <script src="_static/fetch_student_count.js"></script> |
There was a problem hiding this comment.
The script tag should not be prefixed with markdown heading syntax. This is an HTML script element that needs to execute JavaScript to fetch and display student counts dynamically. Adding "## " before it will prevent the script from functioning correctly and may render it as visible text on the page instead of executing it. The script tag should remain as plain HTML without any markdown formatting.
Suggested change
| ## <script src="_static/fetch_student_count.js"></script> | |
| <script src="_static/fetch_student_count.js"></script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.