Ports - Faiza #17
Open
Ports - Faiza #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
May 12, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
This is a solid brute-force solution. However you could get it down to an O(n + m) time complexity using a hash. I encourage you to give it a try.
| # Returns a new array to that contains elements in the intersection of the two input arrays | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n^2) because there are nested loops and n is the length of the input array |
There was a problem hiding this comment.
The two arrays are not guaranteed to be of the same length. This is more accurate to be O(n + m) where n and m are the lengths of the respective arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.