Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions lib/max_subarray.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,19 @@

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def max_sub_array(nums)
Comment on lines +2 to 4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is really elegantly done.

return 0 if nums == nil

raise NotImplementedError, "Method not implemented yet!"
current_max = nums[0]
global_max = nums[0]

i = 1

while i < nums.length
current_max = [nums[i], (current_max + nums[i])].max
global_max = [global_max, current_max].max
i += 1
end

return global_max
end
31 changes: 27 additions & 4 deletions lib/newman_conway.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,30 @@


# Time complexity: ?
# Space Complexity: ?
# Time complexity: O(n)
# Space Complexity: O(1)
def newman_conway(num)
Comment on lines +3 to 5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you have O(1) space complexity? You're building an array. Otherwise well done.

raise NotImplementedError, "newman_conway isn't implemented"
end
raise ArgumentError, "num must be >= 0" if num <= 0
return "1" if num == 1
return "1 1" if num == 2

array = Array.new(num + 1){}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call it something other than just generically array.


# Build a memo of subproblems

array[1] = 1
array[2] = 1

i = 3

while i < array.length

if i > 2
array[i] = array[array[i - 1]] + array[i - array[i - 1]]
end

i += 1
end

array.shift()
return array.join(" ")
end
2 changes: 1 addition & 1 deletion test/max_sub_array_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "max subarray" do
describe "max subarray" do
it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do
# Arrange
input = [-2,1,-3,4,-1,2,1,-5,4]
Expand Down