Seal the capstone OUT/IN-leg public surface + mixed-trigger e2e test#602
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
More reviews will be available in 53 minutes and 16 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughExpands the ChangesKanbanActor Public Surface Seal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…-trigger e2e test The five OUT/IN-leg drivers shipped across #576-#580 were reachable only by module path; lib.rs re-exported just KanbanActor + KanbanMsg. Promote the consumer surface so the live S3 consumer (when it lands in the symbiont golden-image harness, where the lance build fits) can `use` them directly: deliver_kanban_step, drive_mul_advance, drive_scheduled_tick, drive_version_tick, run_to_absorbing, KanbanRouteError. +1 test (15 total green): mixed_triggers_compose_on_one_owner_s2_gate_then_s3_ticks — the capstone integration. The S2 MUL gate takes the first Rubicon step (Flow qualia → Planning->CognitiveWork) and S3 version ticks (run_to_absorbing) carry the rest to Commit, proving the two different triggers compose on one mailbox-as-owner: no panic, no spurious rejection, lands absorbing. clippy + fmt clean; light build (no lance/datafusion/disk). Board hygiene: AGENT_LOG cont.37 prepended. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CcpLeEC3XK8Eye53GKBVvi
aaf7c6f to
266ff88
Compare
What I chose & why
S3-live (wiring a real lance
VersionedGraph::versions()stream) is what I most wanted to finish — but it's disk-walled in this environment (~11 GB free vs ~14–18 GB for the lance/datafusion build; ENOSPC'd twice). Its proper home is the symbiont golden-image harness, which already pulls lance-7, wherever that builds with real disk.So the feasible completion of the arc: seal the capstone's public surface. The five OUT/IN-leg drivers shipped across #576–#580 were reachable only by module path —
lib.rsre-exported justKanbanActor+KanbanMsg. This promotes the consumer surface so the live S3 consumer canuse lance_graph_supervisor::{...}directly when it lands.Changes
lib.rs— re-exportdeliver_kanban_step,drive_mul_advance,drive_scheduled_tick,drive_version_tick,run_to_absorbing,KanbanRouteError.mixed_triggers_compose_on_one_owner_s2_gate_then_s3_ticks, the capstone integration: the S2 MUL gate takes the first Rubicon step (Flow qualia →Planning→CognitiveWork) and S3 version ticks (run_to_absorbing) carry the rest toCommit. Proves the two different triggers compose on one mailbox-as-owner — no panic, no spurious rejection, lands absorbing.clippy + fmt clean; light build (no lance/datafusion, no disk gate).
Remaining (disk-gated, not here)
S3 live
versions()source + S2 shader-driver per-row loop — both need the heavy lance build, to be done in the symbiont harness where it fits.Board hygiene
.claude/board/AGENT_LOG.md— cont.³⁷ prepended.🤖 Generated with Claude Code
Generated by Claude Code
Summary by CodeRabbit
Tests
Chores