Skip to content

Seal the capstone OUT/IN-leg public surface + mixed-trigger e2e test#602

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/jirak-math-theorems-harvest-rfii13
Jun 23, 2026
Merged

Seal the capstone OUT/IN-leg public surface + mixed-trigger e2e test#602
AdaWorldAPI merged 1 commit into
mainfrom
claude/jirak-math-theorems-harvest-rfii13

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Jun 23, 2026

Copy link
Copy Markdown
Owner

What I chose & why

S3-live (wiring a real lance VersionedGraph::versions() stream) is what I most wanted to finish — but it's disk-walled in this environment (~11 GB free vs ~14–18 GB for the lance/datafusion build; ENOSPC'd twice). Its proper home is the symbiont golden-image harness, which already pulls lance-7, wherever that builds with real disk.

So the feasible completion of the arc: seal the capstone's public surface. The five OUT/IN-leg drivers shipped across #576#580 were reachable only by module path — lib.rs re-exported just KanbanActor + KanbanMsg. This promotes the consumer surface so the live S3 consumer can use lance_graph_supervisor::{...} directly when it lands.

Changes

  • lib.rs — re-export deliver_kanban_step, drive_mul_advance, drive_scheduled_tick, drive_version_tick, run_to_absorbing, KanbanRouteError.
  • +1 test (15 total green)mixed_triggers_compose_on_one_owner_s2_gate_then_s3_ticks, the capstone integration: the S2 MUL gate takes the first Rubicon step (Flow qualia → Planning→CognitiveWork) and S3 version ticks (run_to_absorbing) carry the rest to Commit. Proves the two different triggers compose on one mailbox-as-owner — no panic, no spurious rejection, lands absorbing.

clippy + fmt clean; light build (no lance/datafusion, no disk gate).

Remaining (disk-gated, not here)

S3 live versions() source + S2 shader-driver per-row loop — both need the heavy lance build, to be done in the symbiont harness where it fits.

Board hygiene

.claude/board/AGENT_LOG.md — cont.³⁷ prepended.

🤖 Generated with Claude Code


Generated by Claude Code

Summary by CodeRabbit

  • Tests

    • Added end-to-end integration test for multi-stage trigger composition and workflow progression validation.
  • Chores

    • Expanded public API exports with additional actor driver functions and types.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@AdaWorldAPI, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 16 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a7fa19db-ab91-4521-809c-cfb8a1b337b5

📥 Commits

Reviewing files that changed from the base of the PR and between aaf7c6f and 266ff88.

📒 Files selected for processing (3)
  • .claude/board/AGENT_LOG.md
  • crates/lance-graph-supervisor/src/kanban_actor.rs
  • crates/lance-graph-supervisor/src/lib.rs
📝 Walkthrough

Walkthrough

Expands the lance-graph-supervisor crate's public API by adding re-exports of driver/routing functions (deliver_kanban_step, drive_mul_advance, drive_scheduled_tick, drive_version_tick, run_to_absorbing) and KanbanRouteError in lib.rs. Adds an end-to-end integration test composing S2 and S3 triggers on one KanbanActor owner and verifies the full Rubicon phase progression to Commit. Updates the agent log accordingly.

Changes

KanbanActor Public Surface Seal

Layer / File(s) Summary
Expanded kanban_actor public re-exports
crates/lance-graph-supervisor/src/lib.rs
Replaces the minimal pub use kanban_actor list with a broader export including deliver_kanban_step, drive_mul_advance, drive_scheduled_tick, drive_version_tick, run_to_absorbing, and KanbanRouteError, alongside the existing KanbanActor and KanbanMsg.
Mixed S2/S3 trigger integration test
crates/lance-graph-supervisor/src/kanban_actor.rs
Adds mixed_triggers_compose_on_one_owner_s2_gate_then_s3_ticks: spawns a KanbanActor backed by TestBoard, drives S2 via drive_mul_advance asserting a CognitiveWork move target, then advances S3 via run_to_absorbing asserting EvaluationCommit arc, and confirms final KanbanMsg::Phase RPC returns Commit.
AGENT_LOG update
.claude/board/AGENT_LOG.md
Prepends a 2026-06-23 entry recording the sealed OUT/IN-leg public surface and the new mixed-trigger test.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • AdaWorldAPI/lance-graph#439: Established the KanbanColumn DAG helpers and KanbanMove.exec: ExecTarget model that the new integration test's Rubicon phase assertions directly exercise.
  • AdaWorldAPI/lance-graph#567: Fixed NodeRow::mul_phase_step phase-advance behavior that drive_mul_advance (now re-exported) and the S2 leg of the new mixed-trigger test depend on.

Poem

🐇 The kanban lanes are sealed and bright,
Re-exports bloom in public light.
S2 gates first, then S3 ticks—
Through CognitiveWork the actor flicks.
From Evaluation to Commit we go,
A hopping trail through states we know! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the main changes: sealing the public surface by re-exporting driver functions and adding a mixed-trigger e2e test.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…-trigger e2e test

The five OUT/IN-leg drivers shipped across #576-#580 were reachable only by
module path; lib.rs re-exported just KanbanActor + KanbanMsg. Promote the
consumer surface so the live S3 consumer (when it lands in the symbiont
golden-image harness, where the lance build fits) can `use` them directly:
deliver_kanban_step, drive_mul_advance, drive_scheduled_tick,
drive_version_tick, run_to_absorbing, KanbanRouteError.

+1 test (15 total green): mixed_triggers_compose_on_one_owner_s2_gate_then_s3_ticks
— the capstone integration. The S2 MUL gate takes the first Rubicon step (Flow
qualia → Planning->CognitiveWork) and S3 version ticks (run_to_absorbing) carry
the rest to Commit, proving the two different triggers compose on one
mailbox-as-owner: no panic, no spurious rejection, lands absorbing.

clippy + fmt clean; light build (no lance/datafusion/disk).

Board hygiene: AGENT_LOG cont.37 prepended.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CcpLeEC3XK8Eye53GKBVvi
@AdaWorldAPI AdaWorldAPI force-pushed the claude/jirak-math-theorems-harvest-rfii13 branch from aaf7c6f to 266ff88 Compare June 23, 2026 17:25
@AdaWorldAPI AdaWorldAPI merged commit 8bfc933 into main Jun 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants