Skip to content

Conversation

@RigidStudios
Copy link
Contributor

@RigidStudios RigidStudios commented Mar 16, 2023

Description

Removes Query#forEach as proposed in #42. Also resolves #47 by renaming Query#iterate to Query#items.

Tasks
  • Tests Modified
  • Tests Passing
Documentation
Linked

Resolves #42
Resolves #47
Resolves AetherInteractiveLtd/docs#2

@RigidStudios RigidStudios added the enhancement New feature or request label Mar 16, 2023
@RigidStudios
Copy link
Contributor Author

@christopher-buss Do we need tests for this? There were never any tests for iterate and forEach, I think it's fine, up to you though.

@christopher-buss
Copy link
Member

I don't think we should do this. I'd rather have an iterate() and a items() method if you want all the items. We'd have to traverse every entity and add it to a table.. just to re-traverse it later on when we want to use it. I'm happy to have both, but I don't want to remove the generalised iterator completely.

I didn't realise you were doing this, I was currently doing it in another branch!

@RigidStudios
Copy link
Contributor Author

Alright, I'll restore iterate but rename to iter() then.

@RigidStudios
Copy link
Contributor Author

I didn't realise you were doing this, I was currently doing it in another branch!

I huffed and puffed about it yesterday, of course I'll do it! 😂

@RigidStudios
Copy link
Contributor Author

Docs done in AetherInteractiveLtd/docs#2

@RigidStudios
Copy link
Contributor Author

We'll prefer #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

ECS: Rename Query#iterate() to Query#items() ECS: Remove forEach on queries

4 participants