Open
Conversation
Core changes for Iceberg + MinIO integration: 1. Docker Compose: Add MinIO service and Iceberg configuration - MinIO for S3-compatible object storage - Iceberg runtime packages for Spark - S3 endpoint and credential configuration 2. Spark Submit: Add Iceberg packages and S3/MinIO configs - iceberg-spark-runtime-3.5_2.12:1.10.0 - hadoop-aws:3.3.4 for S3 filesystem support - Hadoop catalog configuration for Iceberg tables - MinIO S3 endpoint configuration 3. TableUtils: Fix partition detection for Iceberg tables - Disable Hive partition checking (returns empty list) - Treat non-partitioned tables as having all data available - Enables Chronon to process Iceberg tables without partition metadata 4. Build: Enable Spark 3.5 compilation - Set use_spark_3_5 flag for Spark 3.5 compatibility This enables end-to-end data flow: S3/MinIO → Iceberg → Chronon → Iceberg
4699885 to
1562189
Compare
| .sql(s"SHOW PARTITIONS $tableName") | ||
| .collect() | ||
| .map(row => parseHivePartition(row.getString(0))) | ||
| // NUCLEAR OPTION: Disable all partition checking |
Collaborator
There was a problem hiding this comment.
we can not remove the partition, but we should replace parseHivePartition with something parse Iceberg partition
| } | ||
| .map(partitionSpec.shift(_, inputToOutputShift)) | ||
|
|
||
| // NUCLEAR FIX: If no partitions found (Iceberg/non-partitioned tables), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core changes for Iceberg + MinIO integration:
Docker Compose: Add MinIO service and Iceberg configuration
Spark Submit: Add Iceberg packages and S3/MinIO configs
TableUtils: Fix partition detection for Iceberg tables
Build: Enable Spark 3.5 compilation
This enables end-to-end data flow: S3/MinIO → Iceberg → Chronon → Iceberg
Summary
Why / Goal
Test Plan
Checklist
Reviewers