fix: send server discovery logs to stderr to avoid corrupting MCP stdout on Windows#222
Open
pntgoswami18 wants to merge 1 commit intoAgentDeskAI:mainfrom
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
On Windows (and in any setup where the MCP client expects only JSON-RPC on stdout), the server can fail during initialization with:
The MCP protocol reserves stdout for JSON-RPC messages only. This codebase already patches
process.stdout.writeso that only JSON-like output is sent (see the block afternew StdioServerTransport()). That patch is applied afterdiscoverServer()runs. Meanwhile,discoverServer()usesconsole.log()for messages such as "Starting server discovery process" and "Successfully discovered server at...". Those go to stdout and are sent to the MCP client before the filter is active, so the client sees raw text (e.g. starting withS) instead of a JSON message and fails to parse.Solution
Send all server-discovery logging to stderr instead of stdout by changing the
console.logcalls insidediscoverServer()toconsole.error. Discovery messages remain visible for debugging but no longer corrupt the JSON-RPC channel. No wrapper script or new dependencies; the fix is confined to logging indiscoverServer().Other
console.logcalls in this file have been switched toconsole.errorfor consistency, so all diagnostic output uses stderr.Testing