fix(web): terminal doesn't get keyboard focus when opening a session/agent view#2485
Open
mukesher4 wants to merge 1 commit into
Open
Conversation
xterm's term.focus() was never called on attach, so users had to click inside the pane before typing worked. Expose focus() on the AttachableTerminal handle and call it from TerminalPane's mount effect once a session is actually attached. Fixes AgentWrapper#2434 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XtermTerminal.tsx'sAttachableTerminalhandle now exposesfocus: () => term.focus(), and the type inuseTerminalSession.tsdeclares it.TerminalPane.tsx'sAttachedTerminalmount effect callsterminal.focus()once a session is actually attached (handleIdpresent), so the empty-state pane never steals focus.Fixes #2434.
Screen Recording
Test plan
npm run typecheck(frontend)npx vitest run(frontend, 466 tests pass)🤖 Generated with Claude Code