Debian packaging: strip CRLF in maintainer scripts and relax libsagui dependency#17
Merged
Al-Muhandis merged 3 commits intomainfrom Mar 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
libsaguian optional recommended package instead of a hard dependency while still ensuring it is present at post-install configuration time.Originto the control file.Description
normalize_maintainer_scripts()tobuild-deb.shto strip\rline endings fromDEBIAN/postinstandDEBIAN/postrmand call it after copying thedebiandirectory into the staging tree.debian/DEBIAN/controlto removelibsaguifromDepends, add it underRecommendsaslibsagui2 | libsagui, and include anOriginfield.debian/DEBIAN/postinstwith alibsagui_available()check that usesldconfig -pand added a pre-configuration validation that exits with an instructive error if the shared library is not found.Testing
./build-deb.shto recreate the staging tree and confirm the maintainer scripts were normalized and staged files were created (succeeded).bash -non the modifiedbuild-deb.shanddebian/DEBIAN/postinstscripts (succeeded).Codex Task