Debian packaging: normalize maintainer scripts, relax libsagui dependency, and harden postinst DB/bootstrap checks#18
Merged
Al-Muhandis merged 2 commits intomainfrom Mar 26, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
libsaguia hard dependency so package installs on systems without it still succeed while recommending it.postinstscript more robust by detecting loader/library availability and handling MySQL root access that requires a password, with clear warnings if bootstrap is skipped.Description
normalize_maintainer_scripts()tobuild-deb.shto strip DOS line endings fromDEBIAN/postinstandDEBIAN/postrm, and call it after copying thedebiantree into the staging directory.debian/DEBIAN/controlto removelibsaguifromDependsand add it asRecommends: libsagui2 | libsagui, and add anOriginfield.debian/DEBIAN/postinstby addinglibsagui_available()and emitting a warning if the shared library is not found in the dynamic linker cache.postinstto check whethermysql -u rootcan run without a password before performing automatic DB creation and schema import, and emit a warning and skip the bootstrap if root access is denied.Testing
Codex Task