Skip to content

fix: catch serializer errors, prevent OOM on compress error #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlCalzone merged 1 commit into from
Oct 14, 2025
Merged

fix: catch serializer errors, prevent OOM on compress error #532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/lib/db.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,14 @@ export class JsonlDB<V = unknown> {
private entryToLine(key: string, value?: V, timestamp?: number): string {
if (value !== undefined) {
const k = key;
const v = this.options.serializer?.(key, value) ?? value;
let v: any;
try {
v = this.options.serializer?.(key, value);
} catch {
// This can happen when the application defines an invalid serializer
// In this case simply preserve the raw value, so the issue can be fixed without data loss
}
v ??= value;

if (this.options.enableTimestamps && timestamp !== undefined) {
return JSON.stringify({ k, v, ts: timestamp });
Expand Down Expand Up @@ -987,6 +994,11 @@ export class JsonlDB<V = unknown> {
lastCompress = Date.now();
task.done?.resolve();
} catch (e) {
// On error we're likely left with a closed DB file handle, causing further issues.
// Attempt to at least reopen the file
if (!this._handle) {
this._handle = await fs.open(this.filename, "a+");
}
task.done?.reject(e);
}
break;
Expand Down