Fix silent save failure when file write is denied

[srfwb]

Summary

Fixes #2 — MeadowPy silently fails when saving a file it doesn't have write permission to. The unsaved dot disappears even though nothing was written to disk.

What changed

• file_manager.py: save_file() now shows a QMessageBox.critical error dialog when the write fails (same style as existing error dialogs in file_explorer.py)
• workspace_controller.py: action_save() now checks the return value of save_file() — the modified flag and tab title are only updated on success

Impact

All save paths that go through action_save() are fixed:

• Ctrl+S / toolbar / menu Save
• Save-before-Run (F5)
• Save-before-Debug
• Save on tab close
• Save on app exit

Save As was already handling failure correctly.

After fix

• Set a .py file to read-only, open it, edit it, press Ctrl+S — error dialog should appear and the dot should remain
• Save a normal file — should work as before, dot disappears, status bar shows "Saved"

[AlexHettle]

Thanks for getting on this right away! I haven't been able to test this one yet myself, but from running the test suite it looks like it hangs on the file_manager tests and doesn't complete it's testing run, which makes me worried there's an issue worse than just non-updated tests:

Like I mentioned on the last code review I made, just make sure you're keeping the test suite in mind when making changes, I'll circle back and check this again once you've looked into this. Once again thanks for working on this!

[srfwb]

Fixed.

[AlexHettle]

Just tested this. The save error popup now shows correctly for direct Save, Run, and Debug, so this is partially fixed. However, there are still a few cases where MeadowPy continues as if the save succeeded. When I click Run or Debug on a modified file MeadowPy cannot write to, it shows the save error popup but still runs/debugs the old on-disk file. In this scenario, I think Run/Debug should not continue if save-before-run/debug fails. Also, when closing the tab or exiting the app with unsaved changes, MeadowPy shows the “Save before closing?” prompt, but clicking Save behaves as if the file was saved even though it was not. These flows should stop after the failed save, show the save error, and keep the file open and marked unsaved.