Add token for the test CCDB instance#15416
Merged
Merged
Conversation
Before the test instance did not need a token. This has changed, which broke tests that relied on hardcoded HTTP, and not HTTPS. Now the test instance redirects to HTTPS and we need a token.
mrtineide
requested review from
a team,
Barthelemy,
costing and
sawenzel
as code owners
costing
approved these changes
May 20, 2026
Member
|
Currently broken. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the test instance did not need a token. This has changed, which broke tests that relied on hardcoded HTTP/. Now the test instance redirects to HTTPS and we need a token.
I ran the CCDB test again after this change and with also changing the redirect to from 302 to 307 on the server side, it passes the tests again.