Skip to content

Conversation

@hattinf
Copy link
Contributor

@hattinf hattinf commented Dec 2, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:
-tag colours will now update when looking at run details

Notable changes for developers:

Changes made to the database:

@hattinf hattinf added bug Something isn't working frontend labels Dec 2, 2024
@hattinf hattinf self-assigned this Dec 2, 2024
@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 44.10%. Comparing base (14e0a80) to head (2cbe719).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/public/views/Runs/Details/RunDetailsModel.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1805   +/-   ##
=======================================
  Coverage   44.09%   44.10%           
=======================================
  Files         891      891           
  Lines       15922    15922           
  Branches     3006     3006           
=======================================
+ Hits         7021     7022    +1     
+ Misses       8901     8900    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@martinboulais martinboulais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one test that covers the bug first (and expect it to fail), then implement the fix and see if the test pass

@hattinf hattinf requested a review from martinboulais December 4, 2024 15:44
@hattinf hattinf requested a review from martinboulais December 9, 2024 12:48
@hattinf hattinf requested a review from martinboulais January 13, 2025 15:25
martinboulais
martinboulais previously approved these changes Jan 15, 2025
@martinboulais martinboulais self-requested a review January 23, 2025 11:17
@martinboulais martinboulais merged commit 0028a29 into main Jan 23, 2025
22 of 23 checks passed
@martinboulais martinboulais deleted the bug/fhattinf/O2B-1139/Refreshtagslistwhenatagisupdated/created branch January 23, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend

Development

Successfully merging this pull request may close these issues.

4 participants