Skip to content

[O2B-1418] Improve runs start/stop extraction from kafka #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinboulais merged 2 commits into from
Dec 17, 2024
Merged

[O2B-1418] Improve runs start/stop extraction from kafka #1819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b73920
[O2B-1418] Improve runs start/stop extraction from kafka
martinboulais Dec 16, 2024
f532268
Merge branch 'main' into mboulais/O2B-1418/improve-runs-start-stop
martinboulais Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/server/kafka/AliEcsSynchronizer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@

this.ecsRunConsumer = new AliEcsEventMessagesConsumer(kafkaClient, RUN_CONSUMER_GROUP, RUN_TOPICS);
this.ecsRunConsumer.onMessageReceived(async (eventMessage) => {
const { timestamp, runEvent: { environmentId, runNumber, state, transition, lastRequestUser } } = eventMessage;
const { timestamp, runEvent: { environmentId, runNumber, transition, lastRequestUser } } = eventMessage;

Check warning on line 75 in lib/server/kafka/AliEcsSynchronizer.js

View check run for this annotation

Codecov / codecov/patch

lib/server/kafka/AliEcsSynchronizer.js#L75 

Added line #L75 was not covered by tests
const { externalId: externalUserId, name: userName } = lastRequestUser ?? {};

if (state === 'CONFIGURED' && transition === 'START_ACTIVITY') {
if (transition === 'START_ACTIVITY') {

Check warning on line 78 in lib/server/kafka/AliEcsSynchronizer.js

View check run for this annotation

Codecov / codecov/patch

lib/server/kafka/AliEcsSynchronizer.js#L78 

Added line #L78 was not covered by tests
runService
.createOrUpdate(
runNumber,
Expand All @@ -86,7 +86,7 @@
.catch((error) => this._logger.errorMessage(`Failed to save run start for ${runNumber}: ${error.message}`));
}

if (state === 'RUNNING' && transition === 'STOP_ACTIVITY') {
if (transition === 'STOP_ACTIVITY' || transition === 'GO_ERROR') {

Check warning on line 89 in lib/server/kafka/AliEcsSynchronizer.js

View check run for this annotation

Codecov / codecov/patch

lib/server/kafka/AliEcsSynchronizer.js#L89 

Added line #L89 was not covered by tests
runService
.createOrUpdate(
runNumber,
Expand Down
Loading