Skip to content

Conversation

@martinboulais
Copy link
Contributor

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Run definition filter is now using the factorized filtering system

Changes made to the database:

  • N/A

@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 44.00%. Comparing base (3a8cc5e) to head (73fcacf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nts/Filters/RunsFilter/RunDefinitionFilterModel.js 0.00% 14 Missing ⚠️
...nts/Filters/common/filters/SelectionFilterModel.js 0.00% 12 Missing ⚠️
lib/public/views/Runs/Overview/RunsOverviewPage.js 0.00% 4 Missing ⚠️
...mponents/Filters/RunsFilter/runDefinitionFilter.js 0.00% 1 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
- Coverage   44.02%   44.00%   -0.02%     
==========================================
  Files         895      897       +2     
  Lines       15987    15992       +5     
  Branches     3018     3015       -3     
==========================================
  Hits         7038     7038              
- Misses       8949     8954       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais force-pushed the mboulais/O2B-532/improve-runs-overview-run-definition-filter branch 5 times, most recently from 6ec2dab to e7b2c37 Compare January 13, 2025 09:14
@martinboulais martinboulais force-pushed the mboulais/O2B-532/improve-runs-overview-run-definition-filter branch from e7b2c37 to 8c181ef Compare January 20, 2025 09:35
@martinboulais martinboulais force-pushed the mboulais/O2B-532/improve-runs-overview-run-definition-filter branch from 8c181ef to a527733 Compare February 3, 2025 13:54
@martinboulais martinboulais force-pushed the mboulais/O2B-532/improve-runs-overview-run-definition-filter branch from a527733 to a725f1f Compare February 13, 2025 09:28
@martinboulais martinboulais marked this pull request as ready for review February 13, 2025 09:29
@martinboulais martinboulais changed the title [O2B-532] Improve runs overview run definition filter [O2B-536] Improve runs overview run definition filter Feb 13, 2025
@martinboulais martinboulais merged commit c7fc46f into main Feb 13, 2025
21 of 23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-532/improve-runs-overview-run-definition-filter branch February 13, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants