Skip to content

Conversation

@martinboulais
Copy link
Contributor

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Radio buttons are displayed in selection dropdown when options are exclusives

Notable changes for developers:

  • Custom selector can be applied in selection dropdown options for values that are not CSS valid

Changes made to the database:

  • N/A

@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 44.03%. Comparing base (f3937b5) to head (966f17a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nts/common/selection/dropdown/selectionDropdown.js 0.00% 7 Missing ⚠️
...blic/components/common/selection/SelectionModel.js 0.00% 4 Missing ⚠️
...lters/common/combinationOperatorChoiceComponent.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
+ Coverage   43.86%   44.03%   +0.16%     
==========================================
  Files         891      891              
  Lines       15971    15980       +9     
  Branches     3020     3024       +4     
==========================================
+ Hits         7006     7036      +30     
+ Misses       8965     8944      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais force-pushed the mboulais/O2B-532/minor-improvements-to-selection-dropdown branch from 302b3eb to c7b05e2 Compare January 7, 2025 18:34
@martinboulais martinboulais force-pushed the mboulais/O2B-532/minor-improvements-to-selection-dropdown branch from c7b05e2 to c03c84b Compare January 8, 2025 07:47
@martinboulais martinboulais changed the title [O2B-532] Minor improvements to selection dropdown [O2B-536] Minor improvements to selection dropdown Jan 31, 2025
@martinboulais martinboulais merged commit d333be2 into main Jan 31, 2025
22 of 23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-532/minor-improvements-to-selection-dropdown branch January 31, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants