Skip to content

[O2B-1290] Multi run flagging frontend #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
martinboulais merged 73 commits into from
Feb 13, 2025
Merged

[O2B-1290] Multi run flagging frontend #1833

martinboulais merged 73 commits into from
Feb 13, 2025

Conversation

@Jaden505
Copy link
Contributor

@Jaden505 Jaden505 commented Jan 15, 2025 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for developers:

  • QC flag creation page query params now accept a map of run numbers and detector ids instead of separate query params.

@Jaden505
add export qc flags button no logic yet
e6af5d7
@Jaden505
add checkbox to qc button
ab9c131
@Jaden505
update namings and comments for setfqcflags
8016008
@Jaden505
disable set if not atlest one selected
2a17413
@Jaden505
create multiple qc flags creation model and component for handling. N…
54d822e 
…ow shows but incorrect backend
@Jaden505
create some templates for the tests, half working. Also changed some …
100fac5 
…of the backend to accept multiple run ids and detector ids
@Jaden505
update frontend to allign
269a61d
@Jaden505
breaking errors fixed but backend not yet working
b20b8ea
@Jaden505
successfully providing from backend
97ab5c0
@Jaden505
everything loading without errors including frontend and backend
5bcaab8
@Jaden505
displaying tmies
c6f4cba
@Jaden505
remove backend multiple endpoint. now use with filter. update fronten…
1084834 
…d to work with no new endpoint. set multiple button now actually correct redirects
@Jaden505
fetching detectors correctly
1077b3e
@Jaden505
fix overview start/stop not showing
467d673
@Jaden505
now shows table if multiple selected with relevent selected times nam…
dbfb0ed 
…es and numbers
@Jaden505
Progress on detecotr run map implementation
f562474
@Jaden505
basics working
4406053
@Jaden505
minor bug fixes
30f907a
@Jaden505
everything seems to work untested but code is terrible
25942cc
@Jaden505
handle no overlapping times
5205e39
@Jaden505
fix breadcrumbs issue for single qc flag
dd069c3
@Jaden505
updated controller to allow multiple. untested
48c61d7
@Jaden505
Merge branch 'jadenvr/O2B-1290/backend-api-multi-run-flagging' into j…
60a9f9b 
…adenvr/O2B-1290/multi-run-flagging
@Jaden505
working multi qc flag creation but error on qc flag overview page bec…
52284dc 
…ause of rundetectormap query param
@Jaden505
reset backend
f4eaef0
@Jaden505
went for list of objects data format now update frontend for minimum …
40983b1 
…testing
@Jaden505
functional backend
1c64731
@Jaden505
fix tests backend
a2a438d
@Jaden505
fix console remove statements
f54ea01
@Jaden505
fix test to successfully accept multiple created qc flags
231f6d2
Jaden505 and others added 16 commits January 20, 2025 16:50
@Jaden505
old tests working again for frontend
d6981ec
@Jaden505
new frontend tests added
f090448
@Jaden505
fix styling of button and checkbox
f8fab2b
@Jaden505
revert serializable data to be for single qc flag only
839e9ad
@Jaden505
now selected query done in model
083df69
@Jaden505 @martinboulais
Update lib/public/components/qcFlags/isRunSubjectToQc.js
53f65bc 
Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com>
@Jaden505
runs frontlink now in table on creation, and update title
c35be3b
@Jaden505
Merge branch 'main' of github.com:AliceO2Group/Bookkeeping into jaden…
d96f51a 
…vr/O2B-1290/multi-run-flagging
@Jaden505
merge main
e8a554a
@Jaden505
small fixes
8336f26
@Jaden505
add comments
6be304c
@martinboulais
Reworking and finalize work
e7ce719
@martinboulais
Merge branch 'main' into jadenvr/O2B-1290/multi-run-flagging
05c25d0
@martinboulais
Fix linter
4d2caea
@martinboulais
Fix more
f54505b
@martinboulais
Merge branch 'main' into jadenvr/O2B-1290/multi-run-flagging
655a6af
graduta
graduta requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice contribution @Jaden505 and @martinboulais !
While testing I spotted some bugs which I described in comments. Once these are fixed and to prevent future issues, could you please add some tests scenarios for them?

graduta
graduta previously approved these changes Feb 12, 2025
View reviewed changes
@martinboulais martinboulais merged commit d5ac3fc into main Feb 13, 2025
21 of 23 checks passed
@martinboulais martinboulais deleted the jadenvr/O2B-1290/multi-run-flagging branch February 13, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta graduta approved these changes

+1 more reviewer

@martinboulais martinboulais martinboulais left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Jaden505 Jaden505

Labels

frontend

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jaden505 @graduta @martinboulais