Skip to content

Conversation

@martinboulais
Copy link
Contributor

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Refactored runs overveiw detectors filter

Changes made to the database:

  • N/A

@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 44.03%. Comparing base (d333be2) to head (291a001).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/public/services/RemoteDataProvider.js 0.00% 25 Missing ⚠️
...ponents/Filters/RunsFilter/DetectorsFilterModel.js 0.00% 17 Missing ⚠️
lib/public/services/detectors/detectorsProvider.js 0.00% 6 Missing ⚠️
.../detector/ObservableBasedSelectionDropdownModel.js 0.00% 4 Missing ⚠️
lib/public/services/tag/tagsProvider.js 0.00% 4 Missing ⚠️
...public/components/Filters/common/TagFilterModel.js 0.00% 2 Missing ⚠️
...nts/Filters/RunsFilter/detectorsFilterComponent.js 0.00% 1 Missing ⚠️
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 1 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 1 Missing ⚠️
lib/public/views/Tags/Details/TagDetailsModel.js 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1840   +/-   ##
=======================================
  Coverage   44.03%   44.03%           
=======================================
  Files         891      892    +1     
  Lines       15980    15978    -2     
  Branches     3024     3021    -3     
=======================================
  Hits         7036     7036           
+ Misses       8944     8942    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais changed the title [O2B-532] Improve runs overview detectors filter [O2B-536] Improve runs overview detectors filter Jan 29, 2025
@martinboulais martinboulais merged commit f63cacb into main Jan 31, 2025
22 of 23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-532/improve-runs-overview-detectors-filter branch January 31, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants