Skip to content

Conversation

@martinboulais
Copy link
Contributor

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Kafka client will retry indefinitely when retriable errors occurs

Changes made to the database:

  • N/A

@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 25 lines in your changes missing coverage. Please review.

Project coverage is 44.57%. Comparing base (2b56788) to head (2ecc257).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/server/kafka/InfologgerKafkaLogCreator.js 11.53% 23 Missing ⚠️
lib/server/kafka/AliEcsSynchronizer.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1860      +/-   ##
==========================================
- Coverage   44.58%   44.57%   -0.01%     
==========================================
  Files        1011     1012       +1     
  Lines       16981    17007      +26     
  Branches     3053     3060       +7     
==========================================
+ Hits         7571     7581      +10     
- Misses       9410     9426      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

graduta
graduta previously approved these changes Feb 17, 2025
graduta
graduta previously approved these changes Feb 21, 2025
@martinboulais martinboulais merged commit 975189d into main Feb 21, 2025
21 of 23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1412/mark-kafka-retries-to-infinity branch February 21, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants