Skip to content

Conversation

@martinboulais
Copy link
Contributor

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Clicking on button to delete a flag actually mark it as deleted and remove its effective periods instead of removing it from database

Notable changes for developers:

  • N/A

Changes made to the database:

  • Added deleted flag to QC flags in database

@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 20.75472% with 42 lines in your changes missing coverage. Please review.

Project coverage is 44.59%. Comparing base (4b629d2) to head (6afb0c8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ic/views/QcFlags/details/qcFlagDetailsComponent.js 0.00% 38 Missing ⚠️
...lags/ForDataPass/QcFlagsForDataPassOverviewPage.js 0.00% 2 Missing ⚠️
...ons/v1/20250217075020-add-qc-flags-deleted-flag.js 66.66% 1 Missing ⚠️
...iews/QcFlags/ActiveColumns/qcFlagsActiveColumns.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1861      +/-   ##
==========================================
+ Coverage   44.57%   44.59%   +0.01%     
==========================================
  Files        1010     1011       +1     
  Lines       16959    16956       -3     
  Branches     3046     3049       +3     
==========================================
+ Hits         7560     7562       +2     
+ Misses       9399     9394       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martinboulais, thank you for the quick update on what we discussed! PR looks good to me!

@martinboulais martinboulais merged commit 6d2dafc into main Feb 20, 2025
22 of 23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1428/discard-flags-instead-of-delete branch February 20, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants