-
Notifications
You must be signed in to change notification settings - Fork 21
[O2B-1440] Use trigger to update flags on run boundaries change #1878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O2B-1440] Use trigger to update flags on run boundaries change #1878
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
==========================================
+ Coverage 44.61% 44.79% +0.18%
==========================================
Files 1017 1018 +1
Lines 17117 17124 +7
Branches 3089 3089
==========================================
+ Hits 7636 7671 +35
+ Misses 9481 9453 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lags-on-run-boundaries-change
…lags-on-run-boundaries-change
martinboulais
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, the changes looks good to me!
It might make sense to simply put a few tests (for example in run service, on run update?) to test these behaviors, what do you think?
It might also make sense to document this, either in bkp docs or in Jian's codimd.
|
tests added |
…lags-on-run-boundaries-change
…lags-on-run-boundaries-change
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: