Skip to content

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Apr 2, 2025

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • NA

Notable changes for developers:

  • NA

Changes made to the database:

  • Added migration adding trigger which truncate QC flags boundaries when run timestamps are changed

@xsalonx xsalonx added the DB label Apr 2, 2025
@xsalonx xsalonx self-assigned this Apr 2, 2025
@xsalonx xsalonx marked this pull request as draft April 2, 2025 12:32
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.79%. Comparing base (42745bf) to head (a0ebdcb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...328151300-add-qc-flag-boundaries-update-trigger.js 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
+ Coverage   44.61%   44.79%   +0.18%     
==========================================
  Files        1017     1018       +1     
  Lines       17117    17124       +7     
  Branches     3089     3089              
==========================================
+ Hits         7636     7671      +35     
+ Misses       9481     9453      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xsalonx xsalonx marked this pull request as ready for review April 7, 2025 10:08
Copy link
Contributor

@martinboulais martinboulais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, the changes looks good to me!
It might make sense to simply put a few tests (for example in run service, on run update?) to test these behaviors, what do you think?
It might also make sense to document this, either in bkp docs or in Jian's codimd.

@xsalonx
Copy link
Collaborator Author

xsalonx commented Apr 16, 2025

tests added

@xsalonx xsalonx requested a review from martinboulais April 16, 2025 15:58
@xsalonx xsalonx merged commit 28d1e1a into main Apr 30, 2025
23 checks passed
@xsalonx xsalonx deleted the xsalonx/qcf/O2B-1440/use-trigger-to-update-flags-on-run-boundaries-change branch April 30, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants