Skip to content

Conversation

@martinboulais
Copy link
Contributor

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • The binding of gRPC controllers has been sligtly refactored to make it easier to maintain

Changes made to the database:

  • N/A

@martinboulais martinboulais requested a review from graduta as a code owner April 8, 2025 12:11
@martinboulais martinboulais self-assigned this Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.82%. Comparing base (5779184) to head (f13b33c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/server/gRPC/bindGRPCController.js 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1885      +/-   ##
==========================================
+ Coverage   44.80%   44.82%   +0.01%     
==========================================
  Files        1012     1012              
  Lines       17001    17005       +4     
  Branches     3064     3066       +2     
==========================================
+ Hits         7618     7622       +4     
  Misses       9383     9383              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

graduta
graduta previously approved these changes Apr 9, 2025
@martinboulais martinboulais merged commit ea6ec5c into main Apr 9, 2025
23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1437/refactor-grpc-service-definition branch April 9, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants