Skip to content

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Jul 28, 2025

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Add filtering by notBad fraction for each detector at RunsPerDataPass view

Notable changes for developers:

  • Refactor filtersPanelPopover
    • Add filtersPanelSection

Changes made to the database:

  • Adds dataPasses seeders

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 42.39130% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.80%. Comparing base (19367e5) to head (d3cb379).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/components/Filters/common/filtersPanelPopover.js 0.00% 14 Missing ⚠️
.../ActiveColumns/runDetectorsAsyncQcActiveColumns.js 0.00% 14 Missing ⚠️
...public/components/Filters/common/FilteringModel.js 0.00% 7 Missing ⚠️
...uns/RunPerDataPass/RunsPerDataPassOverviewModel.js 0.00% 7 Missing ⚠️
lib/usecases/run/GetAllRunsUseCase.js 81.08% 7 Missing ⚠️
...Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js 0.00% 2 Missing ⚠️
lib/domain/dtos/filters/RunFilterDto.js 83.33% 1 Missing ⚠️
...ervices/qualityControlFlag/QcFlagSummaryService.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1941      +/-   ##
==========================================
+ Coverage   45.77%   45.80%   +0.03%     
==========================================
  Files        1014     1014              
  Lines       16699    16754      +55     
  Branches     3006     3024      +18     
==========================================
+ Hits         7644     7675      +31     
- Misses       9055     9079      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xsalonx xsalonx changed the title o2 b 1348/by each detector [O2B-1348] Filtering not bad data fraction for each detector Jul 28, 2025
@xsalonx xsalonx changed the title [O2B-1348] Filtering not bad data fraction for each detector [O2B-1348] Filtering by not bad data fraction for each detector Jul 28, 2025
@xsalonx xsalonx marked this pull request as ready for review July 29, 2025 10:17
@xsalonx xsalonx requested a review from graduta as a code owner July 29, 2025 10:17
@xsalonx xsalonx requested a review from graduta July 31, 2025 08:56
@xsalonx xsalonx merged commit 38eae5f into main Aug 1, 2025
23 of 24 checks passed
@xsalonx xsalonx deleted the xsalonx/filtering/O2B-1348/by-each-detector branch August 1, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants