Skip to content

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Aug 14, 2025

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Remove AOT and MUON QC flags from overview pages if they are created via gRPC

Notable changes for developers:

  • Add QC flags filtering by createdBy name

Changes made to the database:

  • NA

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.71%. Comparing base (5a2495d) to head (2ab4a27).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ags/ForDataPass/QcFlagsForDataPassOverviewModel.js 0.00% 4 Missing ⚠️
...erver/services/qualityControlFlag/QcFlagService.js 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
+ Coverage   45.70%   45.71%   +0.01%     
==========================================
  Files        1019     1019              
  Lines       16901    16916      +15     
  Branches     3038     3046       +8     
==========================================
+ Hits         7724     7733       +9     
- Misses       9177     9183       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xsalonx xsalonx changed the title [O2B-1468] Exclude flags created via gRPC [O2B-1468] Exclude AOT and MUON QC flags created via gRPC Aug 15, 2025
@xsalonx xsalonx changed the title [O2B-1468] Exclude AOT and MUON QC flags created via gRPC [O2B-1468] Exclude AOT and MUON QC flags created via gRPC from display Aug 15, 2025
@xsalonx
Copy link
Collaborator Author

xsalonx commented Aug 15, 2025

To be merged after #1951

@xsalonx xsalonx changed the title [O2B-1468] Exclude AOT and MUON QC flags created via gRPC from display [O2B-1468] Exclude AOT and MUON QC flags created via gRPC from overview display Aug 15, 2025
@xsalonx xsalonx marked this pull request as ready for review August 20, 2025 12:44
@xsalonx xsalonx requested a review from graduta as a code owner August 20, 2025 12:44
Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in all tests for successfult
Could you please also add tests for failing scenarios? For example I see that if an unsuported operator is provided, an error is thrown

@xsalonx xsalonx requested a review from graduta August 20, 2025 15:06
@xsalonx xsalonx merged commit 2dfedd4 into main Aug 20, 2025
24 checks passed
@xsalonx xsalonx deleted the xsalonx/aot/O2B-1468/exclude-flags-created-by-grpc branch August 20, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants