Skip to content

[PWGJE] Adding RTC selections and more QA histograms #14421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nzardosh merged 5 commits into from
Jan 9, 2026
Merged

[PWGJE] Adding RTC selections and more QA histograms #14421

nzardosh merged 5 commits into from
Jan 9, 2026

Conversation

@dajones2
Copy link
Contributor

@dajones2 dajones2 commented Jan 7, 2026

No description provided.

@github-actions github-actions bot added the pwgje label Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

O2 linter results: ❌ 21 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title PWGJE: Adding RTC selections and more QA histograms [PWGJE] Adding RTC selections and more QA histograms Jan 7, 2026
@alibuild alibuild mentioned this pull request Jan 7, 2026
Merged
dajones2 added a commit to dajones2/O2Physics that referenced this pull request Jan 7, 2026
@dajones2
Merge pull request #11 from alibuild/alibot-cleanup-14421
337780b 
Please consider the following formatting changes to AliceO2Group#14421
fjonasALICE
fjonasALICE previously requested changes Jan 8, 2026
View reviewed changes
@alibuild alibuild mentioned this pull request Jan 8, 2026
Merged
dajones2 added a commit to dajones2/O2Physics that referenced this pull request Jan 8, 2026
@dajones2
Merge pull request #12 from alibuild/alibot-cleanup-14421
6820b39 
Please consider the following formatting changes to AliceO2Group#14421
nzardosh
nzardosh previously approved these changes Jan 8, 2026
View reviewed changes
@nzardosh nzardosh enabled auto-merge (squash) January 8, 2026 12:00
@nzardosh nzardosh requested a review from fjonasALICE January 8, 2026 12:01
fjonasALICE
fjonasALICE reviewed Jan 8, 2026
View reviewed changes
Copy link
Collaborator

@fjonasALICE fjonasALICE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some additional comments. Can you please confirm that:

  1. Your code compiles locally
  2. Your code runs locally

before making a PR

@nzardosh nzardosh disabled auto-merge January 8, 2026 12:27
@alibuild
Copy link
Collaborator

alibuild commented Jan 8, 2026

Error while checking build/O2Physics/o2 for 6820b39 at 2026-01-08 14:01:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14421-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:658:7: error: 's' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Jan 8, 2026
Merged
@dajones2
Merge pull request #13 from alibuild/alibot-cleanup-14421
9f76d0b 
Please consider the following formatting changes to AliceO2Group#14421
@dajones2
Copy link
Contributor Author

dajones2 commented Jan 8, 2026

Can this be approved please?

@nzardosh nzardosh self-requested a review January 9, 2026 12:22
@nzardosh nzardosh enabled auto-merge (squash) January 9, 2026 12:23
@nzardosh nzardosh disabled auto-merge January 9, 2026 22:10
@nzardosh nzardosh enabled auto-merge (squash) January 9, 2026 22:10
@nzardosh nzardosh requested a review from fjonasALICE January 9, 2026 22:11
@nzardosh nzardosh disabled auto-merge January 9, 2026 22:11
@nzardosh nzardosh enabled auto-merge (squash) January 9, 2026 22:11
@nzardosh nzardosh merged commit 8e4b78e into AliceO2Group:master Jan 9, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzardosh nzardosh nzardosh approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

Assignees

No one assigned

Labels

pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dajones2 @alibuild @nzardosh @fjonasALICE