[PWGHF,PWGJE] Adding B+ to the jet workflow #8726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzardosh
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
fjonasALICE,
hahassan7,
jpxrk,
maoyx,
mfaggin,
mfasDa,
mhemmer-cern,
mmazzilli and
vkucera
as code owners
github-actions
bot
changed the title
nzardosh
force-pushed
the
jetsbackup
branch
2 times, most recently
from
d56e03f to
9824443
Compare
nzardosh
changed the title
vkucera
requested changes
Dec 2, 2024
Collaborator
vkucera
left a comment
vkucera
left a comment
There was a problem hiding this comment.
This PR is mixing at least 4 completely independent features and must be adjusted:
- Adding B+ in the jet workflow
- This part has nothing to do with the HF code and should be the only content of this PR (as the title suggests).
- Renaming the common and 3P derived HF tables
- This is not required to add the B+ in jets. It should be done in a separate PR before or after this one.
- Declaring derived HF tables with macros
- This is not required to add the B+ in jets. This part is only relevant to making the HF tables unique as a part of the table content unification. It should be done in a separate PR.
- Factoring out common methods for filling derived HF tables into a utility class
- This is not required to add the B+ in jets and it is duplicating features already covered in the unification PR #8581 . It should be dropped completely.
Comment on lines
-182
to
+133
| void fillTablesCandidate(const T& candidate, const U& prongCharm, const V& prongBachelor, int candFlag, double invMass, | ||
| void fillTablesCandidate(const T& candidate, const U& prongCharm, const V& prongBachelor, int candFlag, float invMass, |
| DECLARE_SOA_TABLE_STAGED(HfBplusMls, "HFBPML", //! Table with candidate selection ML scores | ||
| hf_cand_mc::MlScoreSig, | ||
| DECLARE_SOA_TABLE_STAGED(HfBplusMls, "HFBPML", //! Table with candidate selection ML scores | ||
| hf_cand_mc::MlScoreSig, // why is this the signal ML score instead of the full one? |
Collaborator
There was a problem hiding this comment.
Please remove the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.